[PATCH 06/12] Reintroduce RESET predicate in filters to allow emptying objects.

[Ondrej Zajicek]

On Mon, Sep 30, 2013 at 09:30:46PM +0300, Sergey Popovich wrote:
> Use RESET as predicate to set to empty value of  dynamic attribute
> value in filters. Leave EMPTY for backwad compatibility, altought
> it not documented enywhere.

Well, my previous comment related to this was more like a question for
opinions of others about this naming issue. IMHO, if EMPTY is not reused
as a predicate for testing emptiness, then we just should document it as
an operator of emptying and RESET is unnecessary. It is true that with
'C.len = 0', separate predicate for testing emptiness is not necessary.

> Uninline f_generate_empty() and refactor code in error path.

OK.

BTW, the error path was correct, as the allocated resources would be
freed with configuration anyways.

> Remove MATCH and CONTAINS from keyword list.

OK.

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20131003/42d53208/attachment.asc>