[PATCH v2] Babel: Immediately update hello interval on interface reconfigure.

[Toke Høiland-Jørgensen]

On 20 July 2016 11:46:08 CEST, Ondrej Zajicek <santiago at crfreenet.org> wrote:
>On Tue, Jul 19, 2016 at 06:34:44PM +0200, Toke Høiland-Jørgensen wrote:
>> @@ -1538,8 +1541,10 @@ babel_reconfigure_iface(struct babel_proto *p,
>struct babel_iface *ifa, struct b
>>    if (new->check_link != old->check_link)
>>      babel_iface_update_state(ifa);
>>  
>> -  if (ifa->up)
>> +  if (ifa->up) {
>> +    babel_send_hello(ifa, 0)
>>      babel_iface_kick_timer(ifa);
>> +  }
>
>Is there a reason to send Hello immediately? If hello_interval is
>increased, it is applied only after the already scheduled Hello is
>sent.
>So the condition from RFC ('it SHOULD NOT be increased, except
>immediately before sending a Hello packet.') is fulfilled.

Only consistency: in the current code, changes to the update interval are applied immediately, but changes to the hello interval are not. This could be confusing to a user that changes the config and expects it to take effect immediately (and indeed this was the feedback I got after the release of 1.6; the old thread is in the mailing list archives).

But you're right that both behaviours are within spec :)

-Toke