[PATCH 0/3] babel: Add compression and support for subtlvs

[Toke Høiland-Jørgensen]

Ondrej Zajicek <santiago at crfreenet.org> writes:

> On Mon, Jun 05, 2017 at 11:49:51PM +0200, Toke Høiland-Jørgensen wrote:
>> This patch series adds compression of outgoing IPv6 prefixes to the
>> Babel protocol, and also adds support to the parser for parsing subtlvs
>> as per RFC6126 bis (see
>> https://tools.ietf.org/html/draft-ietf-babel-rfc6126bis-02#section-4.4).
>
> Hi
>
> The subtlv parser looks OK. W.r.t. prefix compression i would prefer if
> it would be done in the same manner as in the other direction (parsing),
> i.e. having u8 def_ip6_prefix[16] in network order in babel_write_state
> and using a memcmp()-like function that returns first differing byte
> instead of using ip6_common_octets().
>
> +      omit = MIN(omit,
> +                MIN(tlv->plen, net6_pxlen(&state->def_ip6_prefix)) / 8);
>
> Note that MIN() is a macro that expands its arguments two times, so it is
> not a good idea to nest them.

OK, will fix and resend. Should I just resend that one patch, or would
you prefer I resend all three (including the dualstack patch) in a
common series?

-Toke