[PATCH 1/9] Adding configuration option --enable-sadr.

Toke Høiland-Jørgensen toke at toke.dk
Tue Mar 7 10:32:06 CET 2017

Dean Luga <dluga93 at gmail.com> writes:

> From: dean <dluga93 at gmail.com>
> It compiles with the macro SADR_OSPF defined.

Quick comment (I'll look over the rest in more detail later): Why is
source address routing guarded by a configure switch? Shouldn't Bird be
able to understand source-specific routing always, and have the use of
them be configurable at runtime?

> +if test "$enable_sadr" = yes ; then
> +fi
> +

See above; but if you *are* going to have a config flag, should it maybe
be something that doesn't have the name of a protocol in it (since there
will be other protocols supporting SADR routing)? :)


More information about the Bird-users mailing list