[PATCH, RFC 2/3] BGP: Correctly handle changes to c->{check_link, bfd} when reconfiguring.

Ondrej Zajicek santiago at crfreenet.org
Thu Mar 9 16:28:43 CET 2017


On Thu, Mar 09, 2017 at 04:30:24PM +0200, Lennert Buytenhek wrote:
> Since the area between 'struct proto_config c' and 'char *password'
> in 'struct bgp_config' is compared using memcmp() in bgp_reconfigure(),
> move ->check_link and ->bfd so that they are part of that area.  Also
> add a note to 'struct bgp_config' to avoid this tripping up people in
> the future.

Having 'check_link' and 'bfd' outside was intentional, they can be
reconfigured without a session flap.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20170309/55790680/attachment.asc>


More information about the Bird-users mailing list