[PATCH] babel: Add support for dual-stack v4/v6 operation

Toke Høiland-Jørgensen toke at toke.dk
Tue May 30 13:37:56 CEST 2017


Ondrej Zajicek <santiago at crfreenet.org> writes:

> On Mon, May 29, 2017 at 10:24:57PM +0200, Toke Høiland-Jørgensen wrote:
>> This adds support for dual-stack v4/v6 operation to the Babel protocol. Routing
>> messages will be exchanged over IPv6, but IPv4 routes can be carried in the
>> messages being exchanged. This matches how the reference Babel
>> implementation (babeld) works.
>
> Hi
>
> Thanks for the patch. I have one major remark - If i undestand it
> correctly, both IPv4 and IPv6 FIBs are always created and used, but
> IPv4 and IPv6 channels may or may not be configured and created.
> Although when a channel is not configured, Babel would not propagate
> routes (as they have to be imported to nest and back exported to Babel
> to be propagated outside), it is still strange to keep received
> routes.

Yeah, that's true I guess. I'll fix that.

> Also channel_is_active() is called but channel may not even exist?

Ah, proto_configure_channel can leave the channel var entirely unset? I
was assuming it was just leaving it in place but inactive. Can I just
check for NULL, then?

-Toke



More information about the Bird-users mailing list