[PATCH RFC 1/2] babel: Define helper macro for looping through TLVs

Toke Høiland-Jørgensen toke at toke.dk
Wed Jul 18 20:35:14 CEST 2018


Ondrej Zajicek <santiago at crfreenet.org> writes:

> On Fri, Jul 13, 2018 at 10:16:16PM +0200, Toke Høiland-Jørgensen wrote:
>> Since we have several places where we loop over a TLV stream, define a
>> helper macro to deal with framing checks and looping.
>
> OK, but it also makes framing errors silent. I think there should be
> error message (like there is in the old code). And perhaps it could be
> called WALK_TLVS, like other iteration macros in BIRD.

Sure, will fix those issues for the next round :)

-Toke



More information about the Bird-users mailing list