A bug in patch from FreeBSD ports

[Ondrej Zajicek]

Hello

There is a patch for BIRD in FreeBSD ports that causes OSPF crash:

https://svnweb.freebsd.org/ports?view=revision&revision=484648

22 	+  if (en->lsa_body && (en->lsa.age == LSA_MAXAGE))
23 	+  {
24 	+    /* en could be an unexpected self-originated lsa in which case nf is NULL */
25 	+    log(L_INFO "%s: Found flushing LSA while originating %I/%d with fib: %p",
26 	+        p->p.name, lsa->nf->fn.prefix, lsa->nf->fn.pxlen, en->nf);
27 	+    en->nf = lsa->nf;
28 	+  }
29 	

lsa->nf here may be NULL.

I would suggest to send BIRD patches for review to the BIRD mailing list
so we can review it and also merge it upstream.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."