[PATCH] Add CLI command to test reconfiguration status

[Kenth Eriksson]

On Tue, 2019-06-11 at 15:42 +0200, Ondrej Zajicek wrote:
> CAUTION: This email originated from outside of the organization. Do
> not click links or open attachments unless you recognize the sender
> and know the content is safe.
> 
> 
> On Tue, Jun 11, 2019 at 02:58:33PM +0200, Kenth Eriksson wrote:
> > This adds the CLI command 'configure status' so that it is possible
> > to
> > check if reconfiguration is done.
> 
> Hi
> 
> We could add this feature, but it should also report more cases
> (the submitted patch covers just first two):
> 
>  - progress
>  - done
>  - progress+queued
>  - config timeout running
> 
The first two could be added without any refactoring. I'm not sure the
latter two can be done without some refactoring. But I can revisit
later and see if it is possible. But at least having progress and done
solves many issues since we want to know when reconfiguration is
complete. Are you willing to let it go upstream with only the first two
included?

> Also i am not 100% sure if separate 'configure status' command is
> necessary, perhaps it could be part of 'show status'. But i have no
> strong strong feeling one way or the other.
> 
Would prefer 'configure status', it makes sense to keep configure
request command and its status together. Also the 'show status' is
composed of lots of other stuff, making it harder to parse out when
remote controlling bird.
> --
> Elen sila lumenn' omentielvo
> 
> Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
> OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3,
> wwwkeys.pgp.net)
> "To err is human -- to blame it on a computer is even more so."