BIRD 2.0.7 segfault in route filters

[Ondrej Zajicek]

On Mon, Dec 28, 2020 at 04:29:25AM +0100, Ondrej Zajicek wrote:
> On Sun, Dec 27, 2020 at 09:58:57PM +0100, Damian Zaremba wrote:
> > Hi,
> > 
> > It appears there is a segfault in the route specific filters, this was
> > initially observed during a `configure`, but appears to be easily
> > reproducible with startup config.
> > 
> > protocol static {
> >   ipv4 {};
> >   route 192.0.2.0/24 via "lo" {
> >      return false;
> >   };
> > }
> 
> Hi
> 
> Thanks for the bugreport, seems to me that the issue is related to 'return'
> at the top-level of the filter, it causes the crash also in regular filter.
> Will check that.

Hi

Attached patch fixes the issue. Top-level return now behaves like
accept/reject and not crash BIRD. But route-specific filters in static
protocol cannot really 'reject' route, they can just modify attributes
(so reject / 'return false' is ignored).

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-top-level-return.patch
Type: text/x-diff
Size: 528 bytes
Desc: not available
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20201228/485470cb/attachment.bin>