OSPF: incorrect path computation for v2.0.5+?

[Kenth Eriksson]

On Thu, 2020-05-21 at 12:43 +0200, Ondrej Zajicek wrote:
> This patch should fix the issue, could you try it?

Looks promising, applied on top of 2.0.7, and a quick test on the 5
node setup looks correct. Will do some more testing.

We definitely need this fix in the pending 2.0.8 :-)

node_1 ~ # birdc
BIRD v2.0.7-11-g16b30256 ready.
bird> show route table master4
Table master4:
0.0.0.0/0            unicast [static1 20:39:15.729] * (254)
        via 10.210.129.1 on eth1
10.210.139.2/32      unicast [direct1 20:44:42.238] * (255)
        dev p1-1-5-1-6
                     unicast [ospfv2_1 20:44:57.045] E1 (145/10) [0.0.139.2]
        via 10.210.139.2 on p1-1-5-1-6
                     unicast [direct1 20:44:42.866] (255)
        dev p1-1-1-1-2
10.210.139.5/32      unicast [direct1 20:59:37.975] * (255)
        dev p1-1-3-1-4
                     unicast [ospfv2_1 20:59:54.045] E1 (145/10) [0.0.139.5]
        via 10.210.139.5 on p1-1-3-1-4
10.210.139.1/32      unicast [direct1 20:39:08.049] * (255)
        dev lo
10.210.139.4/32      unicast [ospfv2_1 21:00:23.044] * E1 (145/20) [0.0.139.4]
        via 10.210.139.5 on p1-1-3-1-4
10.210.129.0/24      unicast [direct1 20:39:15.728] * (255)
        dev eth1
10.210.139.3/32      unicast [ospfv2_1 20:50:04.045] * E1 (145/20) [0.0.139.3]
        via 10.210.139.2 on p1-1-5-1-6
10.0.0.0/20          unicast [direct1 20:38:51.728] * (255)
        dev eth0
bird> show ospf topology ospfv2_1

area 0.0.0.0

        router 0.0.139.1
                distance 0
                router 0.0.139.2 metric 10
                router 0.0.139.2 metric 10
                router 0.0.139.5 metric 10

        router 0.0.139.2
                distance 10
                router 0.0.139.1 metric 10
                router 0.0.139.1 metric 10
                router 0.0.139.3 metric 10
                router 0.0.139.3 metric 10

        router 0.0.139.3
                distance 20
                router 0.0.139.2 metric 10
                router 0.0.139.2 metric 10
                router 0.0.139.4 metric 10

        router 0.0.139.4
                distance 20
                router 0.0.139.3 metric 10
                router 0.0.139.5 metric 10

        router 0.0.139.5
                distance 10
                router 0.0.139.1 metric 10
                router 0.0.139.4 metric 10
bird>