Bug: BFD confuses sessions with identical IPv6 link-local addresses

[Sebastian Hahn]

> On 14. Jan 2021, at 03:51, Ondrej Zajicek <santiago at crfreenet.org> wrote:
> 
> On Fri, Apr 10, 2020 at 11:13:40AM +0200, Sebastian Hahn wrote:
>>> Thanks for the bugreport. You are right, BFD sessions are dispatched just based
>>> on source address regardless of interface, so it is confused by conflicting
>>> link-local addresses. We will fix that, i would expect the same issue could
>>> happen when conflicting private IPs are used in different VRFs.
>> 
>> in the meantime I thought I might try my hand at a patch, as attached here.
>> It seems to work for me in some limited form of testing. I'll be happy to
>> do any and all kinds of revisions as required of course.
> 
> Hi
> 
> (Noticed while looking for some missed / forgotten e-mails)
> 
> Thanks for the patch, merged with some changes (fixed multihop BFD and hashing):
> 
> https://gitlab.nic.cz/labs/bird/-/commit/910adaa08bbd416288797505399ab47f990817e6

Nice! Thanks, and thanks for fixing up my patch.