[PATCH] babel: Keep separate auth PC counters for unicast and multicast

[Toke Høiland-Jørgensen]

Ondrej Zajicek <santiago at crfreenet.org> writes:

> On Thu, Jan 26, 2023 at 11:42:33AM +0100, Toke Høiland-Jørgensen wrote:
>> Ondrej Zajicek <santiago at crfreenet.org> writes:
>> 
>> > On Tue, Jan 24, 2023 at 08:05:41PM +0100, Toke Høiland-Jørgensen wrote:
>> >> > I think that simple sequence numbers work in two cases - if there is
>> >> > sufficient interval between packets, or there is only one packet
>> >> > flying (e.g. LSREQ-LSUPD ping-pong in OSPF). That is approach used in
>> >> > OSPFv2 and OSPFv3, but that is not true in Babel.
>> >> 
>> >> Well, in practice it seems at least the Linux stack is pretty good at
>> >> not reordering packets across a single hop, which means that this patch
>> >> seems to fix the original issue that sparked this whole discussion. So I
>> >> figured I'd send this one first to get the immediate issue on WiFi
>> >> resolved, and follow up with the window tracking stuff later, once I've
>> >> figured out why it breaks stuff...
>> >
>> > OK, i see that fixing the immediate issue is a good idea, will merge.
>> 
>> Great, thanks!
>
> Hi
>
> Forgot about that, merged now:
>
> https://gitlab.nic.cz/labs/bird/-/commit/ee919658948772105d0bd3b4535ba28883484f2c

Great, thanks!

-Toke