[PATCH] birdc: Do not execute cmd on non interactive help request

Ondrej Zajicek santiago at crfreenet.org
Tue Feb 6 19:11:08 CET 2024


On Thu, Dec 28, 2023 at 12:37:26PM +0100, Inrin via Bird-users wrote:
> Hi!
> 
> A pal of mine noticed that `echo <cmd> ? | birdc` executes the command
> <cmd> after showing it's help text is shown. I later confirmed that `birdcl` in
> comparison to `birdc` does not show this behaviour.
> 
> Since this is a non intuitive side effect on birdc's side, here a
> proposed patch to align birdc and birdcl's behaviour.
> 
> Please advise if fixing it on another part might be preferred.
> I chose birdc.c, to minimize the changes needed.

Thanks, merged. Sorry for the delay, i missed / forgot about the patch.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
"To err is human -- to blame it on a computer is even more so."


More information about the Bird-users mailing list