[3.1.2] Queuing an already queued event to another queue is not supported.

[Matt Corallo]

On 6/1/25 8:46 PM, Matt Corallo wrote:
> Oof. and just after I sent this I hit (several times in testing) a SEGFAULT when reconfiguring a 
> session on both ends (to add bfd, note that this is  the 3.1.2-cznic.1~trixie release, hopefully 
> that's enough to pull up the symbols for the positions here):
> 
> [2449561.935213] bird[576051]: segfault at d8 ip 000056552fb27f29 sp 00007fc2e82ff610 error 4 in 
> bird[57f29,56552fae4000+fa000] likely on CPU 6 (core 3, socket 0)
> [2449561.935221] Code: 7b 28 48 8b 43 20 5b ff e0 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 48 83 ec 08 48 
> 83 7e 20 00 74 67 31 c0 f0 48 0f b1 7e 38 75 4a <48> 8b 17 31 c9 48 89 c8 f0 48 0f b1 56 30 75 2c 48 
> 89 d0 f0 48 0f
> [2449852.166876] bird[604662]: segfault at 3000000fe ip 000055a6f3935f29 sp 00007f6f50617610 error 4 
> in bird[57f29,55a6f38f2000+fa000] likely on CPU 4 (core 2, socket 0)
> [2449852.166898] Code: 7b 28 48 8b 43 20 5b ff e0 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 48 83 ec 08 48 
> 83 7e 20 00 74 67 31 c0 f0 48 0f b1 7e 38 75 4a <48> 8b 17 31 c9 48 89 c8 f0 48 0f b1 56 30 75 2c 48 
> 89 d0 f0 48 0f
> 
> At least once the same thing instead failed with
> 
> bird[617699]: Assertion 'e->hook' failed at lib/event.c:239

This one I managed to hit again by just blocking BFD with iptables making it go down.

> And, finally, once only restarting bfd with `restart bfd1`:
> 
> [2451332.372865] bird[649541]: segfault at a0000018 ip 000055d8368bfd7f sp 00007ffe7643f230 error 4 
> in bird[57d7f,55d83687c000+fa000] likely on CPU 9 (core 4, socket 0)
> [2451332.372873] Code: 55 41 54 55 53 48 83 ec 08 4c 8b 67 38 4d 85 e4 75 11 48 83 c4 08 5b 5d 41 5c 
> 41 5d c3 66 0f 1f 44 00 00 48 89 fb 48 8d 6f 38 <49> 8b 7c 24 18 e8 57 99 0a 00 84 c0 0f 84 f4 00 00 
> 00 4d 8d 6c 24
> 
> On 6/1/25 6:14 PM, Matt Corallo wrote:
>> Tried to test 3.1.2 and it mostly seems to work okay, but after some runtime I got the above error 
>> and crash. Sadly don't have a lot more to help debug this, though it may have been during a reload.
>>
>> Thanks,
>> Matt
>