Relaxed handling of OTC attribute

[Radu-Adrian Feurdean]

> On 12 Jun 2025, at 16:12, Erin Shepherd <bird-users at erinshepherd.net> wrote:
> 
> A disadvantage of that, of course, is that you lose peer role checking (although peers supporting roles are very rare today - despite having run with OTC support enabled ourselves for a couple of years now, we have only one bilat on BCIX which advertises role support towards us)

Hi,

You can always check/modify/whatever the OTC attribute for a peer that does not have a role assigned.

The point is:
 - have the RS signal their role (rs_server)
 - if the peer supports roles, enforce the correct one (rs_client, NOT peer, NOT customer)
 - set the OTC, preferably automatically, not by hand
 - still have the routes received with OTC, even if discarded/inactive, instead of having them treated as “withdraw”
   - I may also want to re-announce these routes (as invalid as they are) to some internal collector.
 - include routes with OTC within “receive limit” ????
 - do something other than having 2 log lines for each route received with OTC when it shouldn’t

We still have 1 or 2 pees that still take the routes from one RS (with OTC attribute) and re-announce them to the other RS.

--
Radu-Adrian FEURDEAN
Web : www.franceix.net