[PATCH] Build: call tools/version with sh

[Maria Matejka]

Hello xtex,

thanks for your patch. We have been recently updating the release
tooling and this bad idea mistakenly stayed there.

Applied everywhere relevant (hopefully).

Happy routing! 
Maria

On Fri, May 09, 2025 at 07:14:50AM -0400, xtex via Bird-users wrote:

> From: xtex <xtexchooser at duck.com>
> 
> As tools/version has a shebang line, it should be
> fine to just call it without specifying bash.
> 
> Calling bash explicitly may lead to inconsistency,
> as the first line of tools/version indicates /usr/bin/sh
> but the script is always executed with bash.
> And, it adds bash as a new build dependency.
> 
> Signed-off-by: xtex <xtexchooser at duck.com>
> ---
> Please apply this to both 2.x and 3.x. Thank you!
> ---
>  Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile.in b/Makefile.in
> index bbc1ef29da88..96a5b6eba60a 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -44,7 +44,7 @@ exedir := @exedir@
>  
>  # Find out which version we are actually building
>  # This is rewritten by the release tools by hardcoded version
> -VERSION := $(strip $(shell bash $(srcdir)/tools/version))
> +VERSION := $(strip $(shell $(srcdir)/tools/version))
>  
>  CFLAGS += -DBIRD_VERSION='"$(VERSION)"'
>  
> 
> base-commit: 7ef70b27ef907bba7479989a5376842c893b12bb
> -- 
> 2.49.0
> 

-- 
Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20250510/5915d201/attachment.htm>