<div dir="ltr">I found some time to package using a patch to the latest 1.6.0 release, created from a diff of origin/krt-export-filtr-fix against v1.6.0-34-g768d013 [ seems to be the top three commits ].<div>I hope that's valid. That patch applied without issue, and I wrapped it into a debian patch.</div><div><br><div>I've installed on a few hosts, and I'll report back tomorrow if I get a chance.</div><div><br></div><div>Thanks again for the speedy code :)</div><div><br></div><div><br></div><div>Here's my debian package patch for reference:</div><div><br></div><div><br></div><div><div>cat bird-1.6.0/debian/patches/001-krt-export-filtr-fix.patch </div><div>filter/tree: prefer xmalloc/xfree to malloc/free</div><div>rt-table: fix kernel protocol export filter memory bug</div><div>Index: bird-1.6.0/filter/tree.c</div><div>===================================================================</div><div>--- bird-1.6.0.orig/filter/tree.c<span class="gmail-Apple-tab-span" style="white-space:pre"> </span>2013-11-23 12:29:53.000000000 +0000</div><div>+++ bird-1.6.0/filter/tree.c<span class="gmail-Apple-tab-span" style="white-space:pre"> </span>2016-09-06 21:30:15.435090279 +0100</div><div>@@ -82,7 +82,7 @@</div><div> if (len <= 1024)</div><div> buf = alloca(len * sizeof(struct f_tree *));</div><div> else</div><div>- buf = malloc(len * sizeof(struct f_tree *));</div><div>+ buf = xmalloc(len * sizeof(struct f_tree *));</div><div> </div><div> /* Convert a degenerated tree into an sorted array */</div><div> i = 0;</div><div>@@ -94,7 +94,7 @@</div><div> root = build_tree_rec(buf, 0, len);</div><div> </div><div> if (len > 1024)</div><div>- free(buf);</div><div>+ xfree(buf);</div><div> </div><div> return root;</div><div> }</div><div>Index: bird-1.6.0/nest/rt-table.c</div><div>===================================================================</div><div>--- bird-1.6.0.orig/nest/rt-table.c<span class="gmail-Apple-tab-span" style="white-space:pre"> </span>2016-04-29 10:13:23.000000000 +0100</div><div>+++ bird-1.6.0/nest/rt-table.c<span class="gmail-Apple-tab-span" style="white-space:pre"> </span>2016-09-06 21:30:15.435090279 +0100</div><div>@@ -60,6 +60,21 @@</div><div> static inline void rt_schedule_prune(rtable *tab);</div><div> </div><div> </div><div>+static int rte_update_nest_cnt;<span class="gmail-Apple-tab-span" style="white-space:pre"> </span>/* Nesting counter to allow recursive updates */</div><div>+</div><div>+static inline void</div><div>+rte_update_lock(void)</div><div>+{</div><div>+ rte_update_nest_cnt++;</div><div>+}</div><div>+</div><div>+static inline void</div><div>+rte_update_unlock(void)</div><div>+{</div><div>+ if (!--rte_update_nest_cnt)</div><div>+ lp_flush(rte_update_pool);</div><div>+}</div><div>+</div><div> static inline struct ea_list *</div><div> make_tmp_attrs(struct rte *rt, struct linpool *pool)</div><div> {</div><div>@@ -609,10 +624,18 @@</div><div> if (!rte_is_valid(best0))</div><div> return NULL;</div><div> </div><div>+ /* This non-static function could be called from outside rt-table.c file and</div><div>+ * we need to ensure that a temporary allocated linpool memory @rte_update_pool</div><div>+ * will be freed */</div><div>+ rte_update_lock();</div><div>+</div><div> best = export_filter(ah, best0, rt_free, tmpa, silent);</div><div> </div><div> if (!best || !rte_is_reachable(best))</div><div>+ {</div><div>+ rte_update_unlock();</div><div> return best;</div><div>+ }</div><div> </div><div> for (rt0 = best0->next; rt0; rt0 = rt0->next)</div><div> {</div><div>@@ -646,6 +669,8 @@</div><div> if (best != best0)</div><div> *rt_free = best;</div><div> </div><div>+ rte_update_unlock();</div><div>+</div><div> return best;</div><div> }</div><div> </div><div>@@ -1097,21 +1122,6 @@</div><div> rte_free_quick(old);</div><div> }</div><div> </div><div>-static int rte_update_nest_cnt;<span class="gmail-Apple-tab-span" style="white-space:pre"> </span>/* Nesting counter to allow recursive updates */</div><div>-</div><div>-static inline void</div><div>-rte_update_lock(void)</div><div>-{</div><div>- rte_update_nest_cnt++;</div><div>-}</div><div>-</div><div>-static inline void</div><div>-rte_update_unlock(void)</div><div>-{</div><div>- if (!--rte_update_nest_cnt)</div><div>- lp_flush(rte_update_pool);</div><div>-}</div><div>-</div><div> static inline void</div><div> rte_hide_dummy_routes(net *net, rte **dummy)</div><div> {</div></div><div><br></div><div><br></div><div><br></div></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div><br></div>Cheers,<div>Just</div></div></div>
<br><div class="gmail_quote">On 6 September 2016 at 18:03, Justin Cattle <span dir="ltr"><<a href="mailto:j@ocado.com" target="_blank">j@ocado.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Pavel,<div><br></div><div><br></div><div>Thanks for quick response! I will try that as soon as I can, hopefully in the next couple of days.</div><div>I'll report back as soon as I know.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div data-smartmail="gmail_signature"><div><br></div>Cheers,<div>Just</div></div></div><div><div class="h5">
<br><div class="gmail_quote">On 6 September 2016 at 16:46, Pavel Tvrdík <span dir="ltr"><<a href="mailto:pavel.tvrdik@nic.cz" target="_blank">pavel.tvrdik@nic.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Justin,<div><div><br>
<br>
On 2016-09-05 16:21, Justin Cattle wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
A colleague of mine reported a memory usage issue with the bird daemon<br>
last year, which resulted in a request for a core dump, but we never<br>
followed it up.<br>
I'd like to re-open this discussion and see if anything can be done to<br>
fix it.<br>
<br>
I'll provide some information regarding a production environment,<br>
where the problem is most obvious. But any further details and<br>
diagnostics will have to come from our lab environment.<br>
Please note, in production we mostly run 1.5, but in the lab we are on<br>
1.6, however we see the same symptoms in both environments on both<br>
versions.<br>
<br>
The symptoms are twofold, but potentially related - greater than<br>
expected memory usage reported by the bird daemon itself for the<br>
number of routes, but also massively more memory actually used by the<br>
daemon process.<br>
<br>
When the process is started, we see "normal" memory usage, which then<br>
seems to grow indefinitely in distinct steps, separated by a period of<br>
a few hours.<br>
<br>
In production, this consumes most of the 32G of memory until the<br>
kernel oom-killer to intervenes.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Production:<br>
<br>
BIRD 1.5.0 ready.<br>
<br>
bird> show memory<br>
<br>
BIRD memory usage<br>
<br>
Routing tables: 1405 MB<br>
<br>
Route attributes: 84 kB<br>
<br>
ROA tables: 192 B<br>
<br>
Protocols: 45 kB<br>
<br>
Total: 1405 MB<br>
<br>
bird> show route count<br>
<br>
2273 of 2273 routes for 1142 networks<br>
</blockquote>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
# ps u -p 3441<br>
<br>
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME<br>
COMMAND<br>
<br>
bird 3441 0.1 55.4 18275124 18241540 ? Ssl Aug10 73:39<br>
/usr/sbin/bird -f -u bird -g bird<br>
</blockquote>
<br>
..so that's ~1.4G reported by bird, and ~18G actually consumed by the<br>
process.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Lab:<br>
<br>
BIRD 1.6.0 ready.<br>
<br>
bird> show mem<br>
<br>
BIRD memory usage<br>
<br>
Routing tables: 693 MB<br>
<br>
Route attributes: 28 kB<br>
<br>
ROA tables: 192 B<br>
<br>
Protocols: 41 kB<br>
<br>
Total: 693 MB<br>
<br>
bird> show route count<br>
<br>
175 of 175 routes for 91 networks<br>
</blockquote>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
# ps u -p 29085<br>
<br>
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME<br>
COMMAND<br>
<br>
bird 29085 0.0 14.9 4994852 4915032 ? Ssl Aug05 19:41<br>
/usr/sbin/bird -f -u bird -g bird<br>
</blockquote></blockquote>
<br></div></div>
Thanks for this report. I successfully simulated this weird behavior too. The setting of kernel protocol with some export filter will cause memory leak bug. I prepared fixing commits in branch `krt-export-filtr-fix'<br>
<br>
<a href="https://gitlab.labs.nic.cz/labs/bird/commits/krt-export-filtr-fix" rel="noreferrer" target="_blank">https://gitlab.labs.nic.cz/lab<wbr>s/bird/commits/krt-export-filt<wbr>r-fix</a><br>
<br>
Can you please download it and confirm, that the bug is fixed?<br>
<br>
Best,<br>
Pavel<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
<br>
..so that's ~ 0.7G reported by bird, and ~5G actually consumed by the<br>
process.<br>
<br>
I also attached the bird config from the lab.<br>
<br>
Any help is much appreciated!<br>
Thanks.<br>
<br>
Cheers,<br>
Just<br></span>
Notice: This email is confidential and may contain copyright material<br>
of members of the Ocado Group. Opinions and views expressed in this<br>
message may not necessarily reflect the opinions and views of the<br>
members of the Ocado Group.<br>
<br>
If you are not the intended recipient, please notify us immediately<br>
and delete all copies of this message. Please note that it is your<br>
responsibility to scan this message for viruses.<br>
<br>
Fetch and Sizzle are trading names of Speciality Stores Limited and<br>
Fabled is a trading name of Marie Claire Beauty Limited, both members<br>
of the Ocado Group.<br>
<br>
References to the “Ocado Group” are to Ocado Group plc (registered<br>
in England and Wales with number 7098618) and its subsidiary<br>
undertakings (as that expression is defined in the Companies Act 2006)<br>
from time to time. The registered office of Ocado Group plc is Titan<br>
Court, 3 Bishops Square, Hatfield Business Park, Hatfield, Herts. AL10<br>
9NE.<br>
</blockquote>
</blockquote></div><br></div></div></div>
</blockquote></div><br></div>
<br>
<p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">Notice: This email is confidential and may contain copyright material of members of the Ocado Group. Opinions and views expressed in this message may not necessarily reflect the opinions and views of the members of the Ocado Group. </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">If you are not the intended recipient, please notify us immediately and delete all copies of this message. Please note that it is your responsibility to scan this message for viruses. </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">Fetch and Sizzle are trading names of Speciality Stores Limited and Fabled is a trading name of Marie Claire Beauty Limited, both members of the Ocado Group.</span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">References to the “Ocado Group” are to Ocado Group plc (registered in England and Wales with number 7098618) and its subsidiary undertakings (as that expression is defined in the Companies Act 2006) from time to time. The registered office of Ocado Group plc is Titan Court, 3 Bishops Square, Hatfield Business Park, Hatfield, Herts. AL10 9NE.</span></font></p>