<div dir="ltr">I *think* I have answered my own question. The patch in the email doesn't include the switch to xmalloc that was originally in the krt-export-filtr-fix branch as well.<div><br></div><div>I can see from `git blame` that it's in the previous commit, <wbr>bc00f058154bb4a630d24d64a55b5f<wbr>181d235c63 [ Filter: Prefer xmalloc/xfree to malloc/free ].</div><div><br></div><div>So, it looks like I actually need a290da25a16b7c79d4a7a87f522b4068bca04979 and bc00f058154bb4a630d24d64a55b5f181d235c63.</div><div><br></div><div>Can you please confirm this is correct ?</div><div>Or else advise the best way to patch against the current release ?</div><div><br></div><div><br></div><div class="gmail_extra"><div><div><div><br></div>Cheers,<div>Just</div></div></div>
<br><div class="gmail_quote">On 19 September 2016 at 10:41, Justin Cattle <span dir="ltr"><<a href="mailto:j@ocado.com" target="_blank">j@ocado.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Ok - great.<div><br></div><div>Should this patch apply to the 1.6 released version ok ?</div><div>I was tracking from the krt-export-filtr-fix before, that that is now gone :)</div><div><br></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div><div><br></div>Cheers,<div>Just</div></div></div><div><div>
<br><div class="gmail_quote">On 19 September 2016 at 10:13, Ondrej Zajicek <span dir="ltr"><<a href="mailto:santiago@crfreenet.org" target="_blank">santiago@crfreenet.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On Mon, Sep 19, 2016 at 09:46:03AM +0100, Justin Cattle wrote:<br>
> Hi Pavel,<br>
><br>
><br>
</span><span>> After running with this latest fixup commit for a week, I see mixed results.<br>
><br>
> With the first fix you created, all the processes remained using a very<br>
> small amount of memory, consistently. As per my previous email, around<br>
> 80Mg.<br>
> With the second fix, some of the bird processes are using up to about<br>
> 600Mg, but some are still using more like the 80Mg from the first fix.<br>
> And, there is a mixture in between those two extremes.<br>
><br>
> So my question is - is this normal and expected now, of is there a<br>
> potential issue with the second fix?<br>
<br>
</span>Hi<br>
<br>
We found that there was one minor leak that was overlooked in the second fix.<br>
<br>
You can try attached patch v3.<br>
<div><div><br>
--<br>
Elen sila lumenn' omentielvo<br>
<br>
Ondrej 'Santiago' Zajicek (email: <a href="mailto:santiago@crfreenet.org" target="_blank">santiago@crfreenet.org</a>)<br>
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, <a href="http://wwwkeys.pgp.net" rel="noreferrer" target="_blank">wwwkeys.pgp.net</a>)<br>
"To err is human -- to blame it on a computer is even more so."<br>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br></div></div>
<br>
<p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">Notice: This email is confidential and may contain copyright material of members of the Ocado Group. Opinions and views expressed in this message may not necessarily reflect the opinions and views of the members of the Ocado Group. </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">If you are not the intended recipient, please notify us immediately and delete all copies of this message. Please note that it is your responsibility to scan this message for viruses. </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">Fetch and Sizzle are trading names of Speciality Stores Limited and Fabled is a trading name of Marie Claire Beauty Limited, both members of the Ocado Group.</span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">References to the “Ocado Group” are to Ocado Group plc (registered in England and Wales with number 7098618) and its subsidiary undertakings (as that expression is defined in the Companies Act 2006) from time to time. The registered office of Ocado Group plc is Titan Court, 3 Bishops Square, Hatfield Business Park, Hatfield, Herts. AL10 9NE.</span></font></p>