<div dir="ltr">Hi Pavel,<div><br></div><div><br></div><div>After running with this latest fixup commit for a week, I see mixed results.</div><div><br></div><div>With the first fix you created, all the processes remained using a very small amount of memory, consistently. As per my previous email, around 80Mg.</div><div>With the second fix, some of the bird processes are using up to about 600Mg, but some are still using more like the 80Mg from the first fix. And, there is a mixture in between those two extremes.</div><div><br></div><div>So my question is - is this normal and expected now, of is there a potential issue with the second fix?</div><div><br></div><div><br></div><div>Here is an example range of memory usage, the hosts all have broadly the same route counts, but some advertise and withdraw more routes than others [ although that itself doesn't seem to be related to the size]..</div><div><br></div><blockquote style="margin:0px 0px 0px 40px;border:none;padding:0px"><div>0.08 GB</div><div>0.08 GB</div><div>0.08 GB</div><div>0.08 GB</div><div>0.08 GB</div><div>0.08 GB</div><div>0.09 GB</div><div>0.10 GB</div><div>0.10 GB</div><div>0.10 GB</div><div>0.11 GB</div><div>0.11 GB</div><div>0.11 GB</div><div>0.16 GB</div><div>0.61 GB</div><div>0.61 GB</div><div>0.61 GB</div><div>0.61 GB</div><div>0.61 GB</div><div>0.62 GB</div><div>0.62 GB</div><div>0.62 GB</div><div>0.62 GB</div><div>0.63 GB</div><div>0.63 GB</div></blockquote><div><div><br></div></div><div><br></div><div>Thanks!</div><div><br></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div><br></div>Cheers,<div>Just</div></div></div>
<br><div class="gmail_quote">On 12 September 2016 at 11:29, Justin Cattle <span dir="ltr"><<a href="mailto:j@ocado.com" target="_blank">j@ocado.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks Pavel - I have updated our package and rolled this version out where the previous new package was.<div><br></div><div>As it's a new version, I will leave it a few more days before deploying everywhere now.</div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div data-smartmail="gmail_signature"><div><br></div>Cheers,<div>Just</div></div></div><div><div class="h5">
<br><div class="gmail_quote">On 12 September 2016 at 08:16, Pavel Tvrdík <span dir="ltr"><<a href="mailto:pavel.tvrdik@nic.cz" target="_blank">pavel.tvrdik@nic.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, Justin.<span><br>
<br>
On 2016-09-09 10:45, Justin Cattle wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
Hi Pavel,<br>
<br>
This is looking good for us :)<br>
It's been in the lab for 3 days across 25 hosts, and memory usage<br>
looks absolutely static after process start.<br>
<br>
We have a couple of canary hosts in production too, and they are<br>
showing the same results.<br>
<br></span><span>
Previous to installing the patched version , the process on this host<br>
was using about 17g of Virt Mem - now at about 80Mg, which is a nice<br>
optimisation ;-)<br>
</span></blockquote>
<br>
Good!<span><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I am planning to roll this out over production next week if possible.<br>
I can report back in a few weeks if you like, but it certainly seems<br>
like this is resolved.<br>
</blockquote>
<br></span>
A colleague Ondra Zajicek noticed me that the solution could lead to reading from freed memory. I made a fixup commit (d9c6d180) at the top of branch krt-export-filtr-fix. Please apply the commit too.<br>
<br>
<a href="https://gitlab.labs.nic.cz/labs/bird/commit/d9c6d180e41c7246ccbde8ae4d828d87daa12cf4" rel="noreferrer" target="_blank">https://gitlab.labs.nic.cz/lab<wbr>s/bird/commit/d9c6d180e41c7246<wbr>ccbde8ae4d828d87daa12cf4</a><br>
<br>
It should fix the bug in the better way.<span><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks again for your help on this - we really appreciate it :)<br>
<br>
</blockquote>
<br></span>
You're welcome :)<br>
<br>
Cheers,<br>
Pavel<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Cheers,<br>
Just<br>
On 7 September 2016 at 09:08, Pavel Tvrdík <<a href="mailto:pavel.tvrdik@nic.cz" target="_blank">pavel.tvrdik@nic.cz</a>><br>
wrote:<br>
<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
Hi, Just.<br>
<br>
On 2016-09-06 22:50, Justin Cattle wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I found some time to package using a patch to the latest 1.6.0<br>
release, created from a diff of origin/krt-export-filtr-fix<br>
against<br>
v1.6.0-34-g768d013 [ seems to be the top three commits ].<br>
</blockquote>
<br>
Yes, the top three commits, exactly!<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I hope that's valid. That patch applied without issue, and I<br>
wrapped<br>
it into a debian patch.<br>
<br>
I've installed on a few hosts, and I'll report back tomorrow if I<br>
get<br>
a chance.<br>
</blockquote>
<br>
Great!<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks again for the speedy code :)<br>
<br>
Here's my debian package patch for reference:<br>
<br>
cat bird-1.6.0/debian/patches/001-<wbr>krt-export-filtr-fix.patch<br>
filter/tree: prefer xmalloc/xfree to malloc/free<br>
rt-table: fix kernel protocol export filter memory bug<br>
Index: bird-1.6.0/filter/tree.c<br>
<br>
</blockquote>
==============================<wbr>==============================<wbr>=======<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
--- bird-1.6.0.orig/filter/tree.c 2013-11-23 12:29:53.000000000<br>
+0000<br>
+++ bird-1.6.0/filter/tree.c 2016-09-06 21:30:15.435090279 +0100<br>
@@ -82,7 +82,7 @@<br>
if (len <= 1024)<br>
buf = alloca(len * sizeof(struct f_tree *));<br>
else<br>
- buf = malloc(len * sizeof(struct f_tree *));<br>
+ buf = xmalloc(len * sizeof(struct f_tree *));<br>
<br>
/* Convert a degenerated tree into an sorted array */<br>
i = 0;<br>
@@ -94,7 +94,7 @@<br>
root = build_tree_rec(buf, 0, len);<br>
<br>
if (len > 1024)<br>
- free(buf);<br>
+ xfree(buf);<br>
<br>
return root;<br>
}<br>
Index: bird-1.6.0/nest/rt-table.c<br>
<br>
</blockquote>
==============================<wbr>==============================<wbr>=======<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
--- bird-1.6.0.orig/nest/rt-table.<wbr>c 2016-04-29 10:13:23.000000000<br>
+0100<br>
+++ bird-1.6.0/nest/rt-table.c 2016-09-06 21:30:15.435090279 +0100<br>
@@ -60,6 +60,21 @@<br>
static inline void rt_schedule_prune(rtable *tab);<br>
<br>
+static int rte_update_nest_cnt; /* Nesting counter to allow<br>
recursive<br>
updates */<br>
+<br>
+static inline void<br>
+rte_update_lock(void)<br>
+{<br>
+ rte_update_nest_cnt++;<br>
+}<br>
+<br>
+static inline void<br>
+rte_update_unlock(void)<br>
+{<br>
+ if (!--rte_update_nest_cnt)<br>
+ lp_flush(rte_update_pool);<br>
+}<br>
+<br>
static inline struct ea_list *<br>
make_tmp_attrs(struct rte *rt, struct linpool *pool)<br>
{<br>
@@ -609,10 +624,18 @@<br>
if (!rte_is_valid(best0))<br>
return NULL;<br>
<br>
+ /* This non-static function could be called from outside<br>
rt-table.c<br>
file and<br>
+ * we need to ensure that a temporary allocated linpool memory<br>
@rte_update_pool<br>
+ * will be freed */<br>
+ rte_update_lock();<br>
+<br>
best = export_filter(ah, best0, rt_free, tmpa, silent);<br>
<br>
if (!best || !rte_is_reachable(best))<br>
+ {<br>
+ rte_update_unlock();<br>
return best;<br>
+ }<br>
<br>
for (rt0 = best0->next; rt0; rt0 = rt0->next)<br>
{<br>
@@ -646,6 +669,8 @@<br>
if (best != best0)<br>
*rt_free = best;<br>
<br>
+ rte_update_unlock();<br>
+<br>
return best;<br>
}<br>
<br>
@@ -1097,21 +1122,6 @@<br>
rte_free_quick(old);<br>
}<br>
<br>
-static int rte_update_nest_cnt; /* Nesting counter to allow<br>
recursive<br>
updates */<br>
-<br>
-static inline void<br>
-rte_update_lock(void)<br>
-{<br>
- rte_update_nest_cnt++;<br>
-}<br>
-<br>
-static inline void<br>
-rte_update_unlock(void)<br>
-{<br>
- if (!--rte_update_nest_cnt)<br>
- lp_flush(rte_update_pool);<br>
-}<br>
-<br>
static inline void<br>
rte_hide_dummy_routes(net *net, rte **dummy)<br>
{<br>
</blockquote>
<br>
Looks fine :)<br>
<br>
Cheers,<br>
Just<br>
On 6 September 2016 at 18:03, Justin Cattle <<a href="mailto:j@ocado.com" target="_blank">j@ocado.com</a>> wrote:<br>
<br>
Hi Pavel,<br>
<br>
Thanks for quick response! I will try that as soon as I can,<br>
hopefully in the next couple of days.<br>
I'll report back as soon as I know.<br>
<br>
Cheers,<br>
Just<br>
<br>
On 6 September 2016 at 16:46, Pavel Tvrdík <<a href="mailto:pavel.tvrdik@nic.cz" target="_blank">pavel.tvrdik@nic.cz</a>><br>
wrote:<br>
Hi Justin,<br>
<br>
On 2016-09-05 16:21, Justin Cattle wrote:<br>
Hi,<br>
<br>
A colleague of mine reported a memory usage issue with the bird<br>
daemon<br>
last year, which resulted in a request for a core dump, but we never<br>
followed it up.<br>
I'd like to re-open this discussion and see if anything can be done<br>
to<br>
fix it.<br>
<br>
I'll provide some information regarding a production environment,<br>
where the problem is most obvious. But any further details and<br>
diagnostics will have to come from our lab environment.<br>
Please note, in production we mostly run 1.5, but in the lab we are<br>
on<br>
1.6, however we see the same symptoms in both environments on both<br>
versions.<br>
<br>
The symptoms are twofold, but potentially related - greater than<br>
expected memory usage reported by the bird daemon itself for the<br>
number of routes, but also massively more memory actually used by<br>
the<br>
daemon process.<br>
<br>
When the process is started, we see "normal" memory usage, which<br>
then<br>
seems to grow indefinitely in distinct steps, separated by a period<br>
of<br>
a few hours.<br>
<br>
In production, this consumes most of the 32G of memory until the<br>
kernel oom-killer to intervenes.<br>
<br>
Production:<br>
<br>
BIRD 1.5.0 ready.<br>
<br>
bird> show memory<br>
<br>
BIRD memory usage<br>
<br>
Routing tables: 1405 MB<br>
<br>
Route attributes: 84 kB<br>
<br>
ROA tables: 192 B<br>
<br>
Protocols: 45 kB<br>
<br>
Total: 1405 MB<br>
<br>
bird> show route count<br>
<br>
2273 of 2273 routes for 1142 networks<br>
<br>
# ps u -p 3441<br>
<br>
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME<br>
COMMAND<br>
<br>
bird 3441 0.1 55.4 18275124 18241540 ? Ssl Aug10 73:39<br>
/usr/sbin/bird -f -u bird -g bird<br>
<br>
..so that's ~1.4G reported by bird, and ~18G actually consumed by<br>
the<br>
process.<br>
<br>
Lab:<br>
<br>
BIRD 1.6.0 ready.<br>
<br>
bird> show mem<br>
<br>
BIRD memory usage<br>
<br>
Routing tables: 693 MB<br>
<br>
Route attributes: 28 kB<br>
<br>
ROA tables: 192 B<br>
<br>
Protocols: 41 kB<br>
<br>
Total: 693 MB<br>
<br>
bird> show route count<br>
<br>
175 of 175 routes for 91 networks<br>
<br>
# ps u -p 29085<br>
<br>
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME<br>
COMMAND<br>
<br>
bird 29085 0.0 14.9 4994852 4915032 ? Ssl Aug05 19:41<br>
/usr/sbin/bird -f -u bird -g bird<br>
<br>
Thanks for this report. I successfully simulated this weird<br>
behavior<br>
too. The setting of kernel protocol with some export filter will<br>
cause<br>
memory leak bug. I prepared fixing commits in branch<br>
`krt-export-filtr-fix'<br>
<br>
<a href="https://gitlab.labs.nic.cz/labs/bird/commits/krt-export-filtr-fix" rel="noreferrer" target="_blank">https://gitlab.labs.nic.cz/lab<wbr>s/bird/commits/krt-export-filt<wbr>r-fix</a><br></div></div>
[1] [1]<div><div><br>
<br>
Can you please download it and confirm, that the bug is fixed?<br>
<br>
Best,<br>
Pavel<br>
<br>
..so that's ~ 0.7G reported by bird, and ~5G actually consumed by<br>
the<br>
process.<br>
<br>
I also attached the bird config from the lab.<br>
<br>
Any help is much appreciated!<br>
Thanks.<br>
<br>
Cheers,<br>
Just<br>
Notice: This email is confidential and may contain copyright<br>
material<br>
of members of the Ocado Group. Opinions and views expressed in this<br>
message may not necessarily reflect the opinions and views of the<br>
members of the Ocado Group.<br>
<br>
If you are not the intended recipient, please notify us immediately<br>
and delete all copies of this message. Please note that it is your<br>
responsibility to scan this message for viruses.<br>
<br>
Fetch and Sizzle are trading names of Speciality Stores Limited and<br>
Fabled is a trading name of Marie Claire Beauty Limited, both<br>
members<br>
of the Ocado Group.<br>
<br>
References to the “Ocado Group” are to Ocado Group plc<br>
(registered<br>
in England and Wales with number 7098618) and its subsidiary<br>
undertakings (as that expression is defined in the Companies Act<br>
2006)<br>
from time to time. The registered office of Ocado Group plc is<br>
Titan<br>
Court, 3 Bishops Square, Hatfield Business Park, Hatfield, Herts.<br>
AL10<br>
9NE.<br>
<br>
Notice: This email is confidential and may contain copyright<br>
material<br>
of members of the Ocado Group. Opinions and views expressed in this<br>
message may not necessarily reflect the opinions and views of the<br>
members of the Ocado Group.<br>
<br>
If you are not the intended recipient, please notify us immediately<br>
and delete all copies of this message. Please note that it is your<br>
responsibility to scan this message for viruses.<br>
<br>
Fetch and Sizzle are trading names of Speciality Stores Limited and<br>
Fabled is a trading name of Marie Claire Beauty Limited, both<br>
members<br>
of the Ocado Group.<br>
<br>
References to the “Ocado Group” are to Ocado Group plc<br>
(registered<br>
in England and Wales with number 7098618) and its subsidiary<br>
undertakings (as that expression is defined in the Companies Act<br>
2006)<br>
from time to time. The registered office of Ocado Group plc is<br>
Titan<br>
Court, 3 Bishops Square, Hatfield Business Park, Hatfield, Herts.<br>
AL10<br>
9NE.<br>
<br>
Links:<br>
------<br>
[1]<br>
<a href="https://gitlab.labs.nic.cz/labs/bird/commits/krt-export-filtr-fix" rel="noreferrer" target="_blank">https://gitlab.labs.nic.cz/lab<wbr>s/bird/commits/krt-export-filt<wbr>r-fix</a><br></div></div>
[1]<br>
</blockquote><span>
<br>
Notice: This email is confidential and may contain copyright material<br>
of members of the Ocado Group. Opinions and views expressed in this<br>
message may not necessarily reflect the opinions and views of the<br>
members of the Ocado Group.<br>
<br>
If you are not the intended recipient, please notify us immediately<br>
and delete all copies of this message. Please note that it is your<br>
responsibility to scan this message for viruses.<br>
<br>
Fetch and Sizzle are trading names of Speciality Stores Limited and<br>
Fabled is a trading name of Marie Claire Beauty Limited, both members<br>
of the Ocado Group.<br>
<br>
References to the “Ocado Group” are to Ocado Group plc (registered<br>
in England and Wales with number 7098618) and its subsidiary<br>
undertakings (as that expression is defined in the Companies Act 2006)<br>
from time to time. The registered office of Ocado Group plc is Titan<br>
Court, 3 Bishops Square, Hatfield Business Park, Hatfield, Herts. AL10<br>
9NE.<br>
<br>
Links:<br>
------<br>
[1] <a href="https://gitlab.labs.nic.cz/labs/bird/commits/krt-export-filtr-fix" rel="noreferrer" target="_blank">https://gitlab.labs.nic.cz/lab<wbr>s/bird/commits/krt-export-filt<wbr>r-fix</a><br>
</span></blockquote>
</blockquote></div><br></div></div></div>
</blockquote></div><br></div>
<br>
<p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">Notice: This email is confidential and may contain copyright material of members of the Ocado Group. Opinions and views expressed in this message may not necessarily reflect the opinions and views of the members of the Ocado Group. </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">If you are not the intended recipient, please notify us immediately and delete all copies of this message. Please note that it is your responsibility to scan this message for viruses. </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">Fetch and Sizzle are trading names of Speciality Stores Limited and Fabled is a trading name of Marie Claire Beauty Limited, both members of the Ocado Group.</span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px"> </span></font></p><p style="margin:0px;background-color:rgb(255,255,255)"><font color="#aeaaaa" face="Calibri, sans-serif"><span style="font-size:14.6667px">References to the “Ocado Group” are to Ocado Group plc (registered in England and Wales with number 7098618) and its subsidiary undertakings (as that expression is defined in the Companies Act 2006) from time to time. The registered office of Ocado Group plc is Titan Court, 3 Bishops Square, Hatfield Business Park, Hatfield, Herts. AL10 9NE.</span></font></p>