<html><head></head><body><div class="ydpafa4de5fyahoo-style-wrap" style="font-family: Helvetica Neue, Helvetica, Arial, sans-serif; font-size: 13px;"><div style="font-family: Helvetica Neue, Helvetica, Arial, sans-serif; font-size: 13px;"></div>
<div dir="ltr" data-setdir="false" style="font-family: Helvetica Neue, Helvetica, Arial, sans-serif; font-size: 13px;">Hi Jocke,</div><div dir="ltr" data-setdir="false" style="font-family: Helvetica Neue, Helvetica, Arial, sans-serif; font-size: 13px;"><br></div><div dir="ltr" data-setdir="false" style="font-family: Helvetica Neue, Helvetica, Arial, sans-serif; font-size: 13px;">yes i missed to take care of the ospfv3/ipv6 cases wherever im sending using allospfrouters as src ip.</div><div dir="ltr" data-setdir="false" style="">your are right, <font color="#26282a">mcast changes in packet.c is mostly hack since im not comfortable with the bird code since i have only 1 week of bird code experience.</font></div><div dir="ltr" data-setdir="false" style="">reason i did not change inside <font color="#26282a">ospf_send_to() is,since dst address is one of the parameter to the function and i don't want to override inside it. </font></div><div dir="ltr" data-setdir="false" style=""><font color="#26282a">In Hello.c, <span>ospf_send_hello they do some what similar, checking different interface types before they call ospf_send_to()</span></font></div><div dir="ltr" data-setdir="false" style=""><font color="#26282a"><span><br></span></font></div><div dir="ltr" data-setdir="false" style=""><font color="#26282a"><span>Thanks and Regards,</span></font></div><div dir="ltr" data-setdir="false" style=""><font color="#26282a"><span>Senthil</span></font></div><div style="font-family: Helvetica Neue, Helvetica, Arial, sans-serif; font-size: 13px;"><br></div>
</div><div id="ydp675c555cyahoo_quoted_0796627820" class="ydp675c555cyahoo_quoted">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div>
On Friday, May 7, 2021, 06:14:16 PM GMT+5:30, Joakim Tjernlund <joakim.tjernlund@infinera.com> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div dir="ltr">On Thu, 2021-05-06 at 17:09 +0000, Senthil Kumar Nagappan wrote:<div class="ydp675c555cyqt2766737085" id="ydp675c555cyqtfd32782"><br clear="none">> Hi,<br clear="none">> <br clear="none">> I did sent this message a week back but I could not see it in the mailing, moreover just now subscribed to this mailing list, so sending this again.<br clear="none">> <br clear="none">> I’m seeing some issues with ospf adj over ptp numbered/unnumbered interface. <br clear="none">> <br clear="none">> 1. For p2p connections, ospf should be sending only multicast packets to allospfrouters, but I see its sending to unicast address.<br clear="none">> (From RFC “On physical point-to-point networks, the IP destination is always set to the address AllSPFRouters”)<br clear="none">> 2. For ptp over unnumbered interface, bird requires peer address configuration which is not required from the ospf perspective. Because bird is using peer address and sending<br clear="none">> unicast packets, bird cannot form multiple ospf adj over ptp unnumbered interface between 2 endpoints using same peer address.<br clear="none">> Made some quick changes and have attached the patch that addresses the issues. Relaxed the source ip address validation for ptp link in packet.c for now. More validation can be<br clear="none">> added to make it complete.<br clear="none">> <br clear="none">> Thanks and Regards,<br clear="none">> Senthil</div><br clear="none">> <br clear="none"><br clear="none">Hi Senthil<br clear="none"><br clear="none">I took a closer look at your hack/patch ...<br clear="none">You seem to miss correcting a few ospf_send_to() call sites. I wonder in its not better to<br clear="none">override the dst addr inside ospf_send_to() instead?<br clear="none"><br clear="none">Also, the mcast changes in packet.c looks incomplete, there is IPv6 and and area == 0 further down<br clear="none">to consider.<br clear="none"><br clear="none"> Jocke <div class="ydp675c555cyqt2766737085" id="ydp675c555cyqtfd92505"><br clear="none"></div></div></div>
</div>
</div></body></html>