<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello Maria!</p>
<p>Correct! The AS_PATH_SET's are being depreciated. In the
meantime they are slipping into the algorithm which they should
not be.</p>
<p>The bird code correctly checks for the confed but skips the ckeck
for the non-confed sets.</p>
<p>Below is what I proposed adding:<br>
</p>
<p><font face="monospace">enum aspa_result aspa_check(rtable *tab,
const adata *path, bool force_upstream)<br>
{<br>
struct lp_state lps;<br>
lp_save(tmp_linpool, &lps);<br>
<br>
/* No support for confed paths */<br>
if (as_path_contains_confed(path))<br>
return ASPA_INVALID;<br>
<br>
/* No support for as sets */<br>
if (as_path_contains_set(path)) <--- missing in
2.16<br>
return ASPA_INVALID;<br>
<br>
/* Check path length */<br>
uint len = as_path_getlen(path);<br>
if (len == 0)<br>
return ASPA_INVALID;<br>
</font><br>
Thanks!<br>
</p>
<pre class="moz-signature" cols="72">Ralph Covelli
Network Engineer
Hurricane Electric / AS6939</pre>
<div class="moz-cite-prefix">On 1/9/2025 9:35 AM, Maria Matejka via
Bird-users wrote:<br>
</div>
<blockquote type="cite"
cite="mid:Z3_elKbK-Z9nvD-u@livanecnik.jmq.cz">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<meta charset="utf-8">
<meta name="generator" content="pandoc">
<meta name="viewport"
content="width=device-width, initial-scale=1.0, user-scalable=yes">
<style>html {
line-height: 1.2;
font-family: serif;
font-size: 0.9em;
color: black;
background-color: white;
}body {
margin: 0;
margin-right: auto;
max-width: 36em;
padding: 1em;
hyphens: auto;
overflow-wrap: break-word;
text-rendering: optimizeLegibility;
font-kerning: normal;
}p {
margin: 1em 0;
}a {
color: black;
}a:visited {
color: black;
}img {
max-width: 100%;
}h1, h2, h3, h4, h5, h6 {
margin-top: 1.4em;
}h5, h6 {
font-size: 1em;
font-style: italic;
}h6 {
font-weight: normal;
}ol, ul {
padding-left: 1.7em;
margin-top: 1em;
}li > ol, li > ul {
margin-top: 0;
}blockquote {
margin: 0.5em;
padding-left: 0.5em;
border-left: 2px solid #e6e6e6;
color: #444;
}code {
font-family: 'Lucida Console', monospace;
font-size: 95%;
margin: 0;
}pre {
margin: 1em 0;
overflow: auto;
max-width: unset;
width: fit-content;
}pre code {
padding: 0;
overflow: visible;
overflow-wrap: normal;
max-width: unset;
white-space: pre-wrap;
}pre code span {
white-space: pre;
}.sourceCode {
background-color: transparent;
overflow: visible;
}code.diff span.kw,
code.diff span.dt {
font-weight: bold;
}code.diff span.va {
background-color: rgba(192, 255, 192, 64);
color: rgb(0, 64, 0);
}code.diff span.st {
background-color: rgba(255, 192, 192, 64);
color: rgb(64, 0, 0);
}pre.diff {
background-color: rgb(240, 240, 240);
padding: 0.4em;
border: 1pt solid grey;
}hr {
background-color: black;
border: none;
height: 1px;
margin: 1em 0;
}table {
margin: 1em 0;
border-collapse: collapse;
width: 100%;
overflow-x: auto;
display: block;
font-variant-numeric: lining-nums tabular-nums;
}table caption {
margin-bottom: 0.75em;
}tbody {
margin-top: 0.5em;
border-top: 1px solid black;
border-bottom: 1px solid black;
}th {
border-top: 1px solid black;
padding: 0.25em 0.5em 0.25em 0.5em;
}td {
padding: 0.125em 0.5em 0.25em 0.5em;
}header {
margin-bottom: 4em;
text-align: center;
}code{white-space: pre-wrap;}span.smallcaps{font-variant: small-caps;}span.underline{text-decoration: underline;}div.column{display: inline-block; vertical-align: top; width: 50%;}div.hanging-indent{margin-left: 1.5em; text-indent: -1.5em;}ul.task-list{list-style: none;}q { quotes: "„" "”" "»" "«"; }.display.math{display: block; text-align: center; margin: 0.5rem auto;}</style>
<p>Hello Ralph,</p>
<blockquote>
<blockquote>
<p>I talked to Job. It looks like they have no interest in
easing the
transition for stragglers who are still announcing AS_SETs
in their
AS_PATHs.</p>
<p>All AS_SETs should result in ASPA_INVALID.</p>
<p>I also just learned the Dutch have a saying… “soft doctors
make
wounds stink”.</p>
</blockquote>
<p>At one point it seems like there was a helper function
already
written for this that has been lost in time. It used to be
right next
to as_path_contains_confed() in the code.</p>
<p>Maybe its time to bring it back? :-)</p>
</blockquote>
<p>Well, maybe as a method for an AS Path in filters, to allow
people
reject and log these paths.</p>
<p>Definitely not to be used in the ASPA check. With that, we are
on the
same page as Job. Also, there is an upcoming RFC draft banning
AS_SETs
altogether, and we are very much looking forward to implementing
it.</p>
<p><a
href="https://datatracker.ietf.org/doc/draft-ietf-idr-deprecate-as-set-confed-set/"
class="uri moz-txt-link-freetext" moz-do-not-send="true">https://datatracker.ietf.org/doc/draft-ietf-idr-deprecate-as-set-confed-set/</a></p>
<p>Thank you for your understanding.</p>
<p>Maria</p>
<p>–<br>
Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o.</p>
</blockquote>
</body>
</html>