Does repeated config timeout work as single (first one) accumulated?
IOW, let's say we have config version 1. Then if config has been changed (become version 2) and temporarily applied with config timeout 10 and then before it's been rolled back (assuming control still isn't lost of course), entered config timeout 30 would it be effectively the same as if you'd have entered just "config timeout 40" in the first time? Or would the second "config timeout" commit version 2 instead and when timeout is reached would rollback from version 3 (which is equal by content to version 2) to version 2 instead of version 1? -- End of message. Next message?
On Thu, Jan 17, 2019 at 12:38:11AM +0700, Igor Podlesny wrote:
Or would the second "config timeout" commit version 2 instead and when timeout is reached would rollback from version 3 (which is equal by content to version 2) to version 2 instead of version 1?
Yes, this way. There is just one 'old configuration' slot that is used for rollbacks. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
On Thu, 17 Jan 2019 at 02:25, Ondrej Zajicek <santiago@crfreenet.org> wrote:
On Thu, Jan 17, 2019 at 12:38:11AM +0700, Igor Podlesny wrote:
Or would the second "config timeout" commit version 2 instead and when timeout is reached would rollback from version 3 (which is equal by content to version 2) to version 2 instead of version 1?
Yes, this way. There is just one 'old configuration' slot that is used for rollbacks.
Thanks! But birdc won't show any confirmation/warning that it's applied, right? -- End of message. Next message?
On Thu, 17 Jan 2019 at 02:31, Igor Podlesny <bird.user@poige.ru> wrote:
On Thu, 17 Jan 2019 at 02:25, Ondrej Zajicek <santiago@crfreenet.org> wrote:
On Thu, Jan 17, 2019 at 12:38:11AM +0700, Igor Podlesny wrote:
Or would the second "config timeout" commit version 2 instead and when timeout is reached would rollback from version 3 (which is equal by content to version 2) to version 2 instead of version 1?
Yes, this way. There is just one 'old configuration' slot that is used for rollbacks.
Thanks! But birdc won't show any confirmation/warning that it's applied, right?
To improve birdc giving its users more convenient and often _expected_ behaviour -- it's only needed to check on "config timeout" request if another postponed rollback had been already scheduled and if there were no config changes interim, just to postpone current rollback accordingly -- using freshly entered timeout value of course. Easy, clean and very convenient fix allowing to start with short interval of rollback and consequentially increase it -- kinda "manual anti-slow-start": allowing to rollback fast if changes led to lost of control almost immediately but also allowing to do auto rollback if lost of control happened a bit later. -- End of message. Next message?
participants (2)
-
Igor Podlesny -
Ondrej Zajicek