[PATCH] Maximum include depth in Bird config
Hi all, The page at http://bird.network.cz/?get_doc&f=bird-3.html , section 3.2 (as well as doc/bird.sgml), states that "the maximal depth [of inclusion of a new file in a Bird config] is 5". However, effective depth since July, 18, 2012, is 8 (9eceab33:conf/cf-lex.l:82). Maybe the user's guide needs an update, or depth 8 is unsupported? Just in case, patch goes below. Signed-off-by: Artyom Gavrichenkov <ximaera@qrator.net> --- doc/bird.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/bird.sgml b/doc/bird.sgml index fa4c777..beacd4b 100644 --- a/doc/bird.sgml +++ b/doc/bird.sgml @@ -318,7 +318,7 @@ protocol rip { <p><descrip> <tag>include "<m/filename/"</tag> This statement causes inclusion of a new file. <m/Filename/ could also - be a wildcard. The maximal depth is 5. Note that this statement could be + be a wildcard. The maximal depth is 8. Note that this statement could be used anywhere in the config file, not just as a top-level option. <tag><label id="dsc-log">log "<m/filename/"|syslog [name <m/name/]|stderr all|{ <m/list of classes/ }</tag> -- 1.8.1.2
On Tue, Jun 10, 2014 at 05:18:14AM +0400, Artyom Gavrichenkov wrote:
Hi all,
The page at http://bird.network.cz/?get_doc&f=bird-3.html , section 3.2 (as well as doc/bird.sgml), states that "the maximal depth [of inclusion of a new file in a Bird config] is 5". However, effective depth since July, 18, 2012, is 8 (9eceab33:conf/cf-lex.l:82).
Maybe the user's guide needs an update, or depth 8 is unsupported?
Yes, the guide needs an update. Thanks for the patch. BTW, i wonder how did you noticed that? Trying to have some deep include structure or just reading the source? -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
10.06.2014 14:14, Ondrej Zajicek пишет:
BTW, i wonder how did you noticed that? Trying to have some deep include structure or just reading the source?
Just reading the source. The number 5 seemed strange to me (it's not a power of 2, you know), so I tried to find out why it is 5. -- | Artyom Gavrichenkov | Engineer, R&D Team, Qrator Labs | http://qrator.net/ | gpg: fa1c670e | mailto: ximaera@qrator.net | skype: xima_era | tel. no: +7 916 515 49 58
participants (2)
-
Artyom Gavrichenkov -
Ondrej Zajicek