Hi All, After investigate the codes for command "configure", found that when delete/add channel, the function proto_configure_channel() always return value "1" , that mean the same is true in function bgp_reconfigure(), line 917 of proto.c will ignore the change(add/delete channel).... Is my understand correct ? Thanks Arvin From: Arvin Gan Sent: Friday, June 22, 2018 5:23 PM To: bird-users@network.cz Subject: BGP channel add/remove Hi All, I am using Bird 2.0.2 version, I create a BGP instance with one channel IPV4, that all work normally. Then I modified configuration file and add new channel IPV6, and using command "configure" under birdc , found the new added channel IPV6 is not announced to peer and channel ipv6 is down state. Then I used "restart bgp", all channels IPV4 and IPV6 are announced, work normally. I also do another test that delete channel in configure file and used "configure", it work normally. Anyone know the difference of actions between "configure" and "restart "? The command "configure" can dynamically modify the BGP protocol configuration, cant the action "configure" re-announce the added/removed capability to peer to update ? Appreciated your help in advance...... Thanks Arvin
On Mon, Jun 25, 2018 at 07:23:09AM +0000, Arvin Gan wrote:
Hi All, After investigate the codes for command "configure", found that when delete/add channel, the function proto_configure_channel() always return value "1" , that mean the same is true in function bgp_reconfigure(), line 917 of proto.c will ignore the change(add/delete channel).... Is my understand correct ?
Yes. But the main problem is that generally the infrastructure for adding/removing channels during reconfigure is insufficient to handle that properly. Protocol-specific code can decide whether to force-restart channel in e.g. bgp_channel_reconfigure() for channel reconfiguration, but not for channel add/remove. Although it could be probably hacked in general bgp_reconfigure() hook. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
participants (2)
-
Arvin Gan -
Ondrej Zajicek