Problem with if statements containing && or || expressions
Hello, I'm having problems with if statements containing &&, or ||. Why do the config file below cause the following error? $ ./bird -d -l bird: filters, line 8: Argument 2 of AND must be of type bool, got type int bird: bird.conf:15:12 Runtime error while evaluating expression; see log for details # bird.conf function dummy() { return 1; } function test() { if (dummy() != 0) && true then { print "Success"; } return 0; } eval test(); protocol device { interface "*"; } /Mikael
On Sat, Jan 04, 2020 at 09:46:52PM +0100, mikma.bird@lists.m7n.se wrote:
Hello,
I'm having problems with if statements containing &&, or ||. Why do the config file below cause the following error?
Hello Works for me in current devel branch. In which version do you experience the error? 2.0.7 or older? -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
On 2020-01-06 04:26, Ondrej Zajicek wrote:
On Sat, Jan 04, 2020 at 09:46:52PM +0100, mikma.bird@lists.m7n.se wrote:
Hello,
I'm having problems with if statements containing &&, or ||. Why do the config file below cause the following error?
Hello
Works for me in current devel branch. In which version do you experience the error? 2.0.7 or older?
I used the current devel branch (commit cc75b3e1). And I have built it on three systems (all x86_64), Ubuntu 18.04, 19.10, and CentOS 7.7, all with the same error when running the test case. I have made a "git bisect" now and found 10c4cd96 is the first bad commit using the same test case. After reverting commit 10c4cd96 I get "Success" on the test case. Result from git bisect: 10c4cd9677555e88a4ac8c95784aa281655e3326 is the first bad commit commit 10c4cd9677555e88a4ac8c95784aa281655e3326 Author: Ondrej Zajicek (work) <santiago@crfreenet.org> Date: Tue Nov 5 15:14:57 2019 +0100 Filter: Add type info for more instructions :040000 040000 6447441306f4d6300986d78eac3efeb92bde656c 2bbef7a1e0d4c6e3d7b61e2f0700fba04a3917ba M filter /Mikael
On Mon, Jan 06, 2020 at 11:49:15AM +0100, mikma.bird@lists.m7n.se wrote:
On 2020-01-06 04:26, Ondrej Zajicek wrote:
On Sat, Jan 04, 2020 at 09:46:52PM +0100, mikma.bird@lists.m7n.se wrote:
Hello,
I'm having problems with if statements containing &&, or ||. Why do the config file below cause the following error?
Hello
Works for me in current devel branch. In which version do you experience the error? 2.0.7 or older?
I used the current devel branch (commit cc75b3e1). And I have built it on three systems (all x86_64), Ubuntu 18.04, 19.10, and CentOS 7.7, all with the same error when running the test case.
Thanks, can replicate it. Expect it to be parse-time error but it is actuall runtime error. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
On Mon, Jan 06, 2020 at 11:49:15AM +0100, mikma.bird@lists.m7n.se wrote:
On 2020-01-06 04:26, Ondrej Zajicek wrote:
On Sat, Jan 04, 2020 at 09:46:52PM +0100, mikma.bird@lists.m7n.se wrote:
Hello,
I'm having problems with if statements containing &&, or ||. Why do the config file below cause the following error?
Hello
Works for me in current devel branch. In which version do you experience the error? 2.0.7 or older?
I used the current devel branch (commit cc75b3e1). And I have built it on three systems (all x86_64), Ubuntu 18.04, 19.10, and CentOS 7.7, all with the same error when running the test case.
Thanks, fixed: https://gitlab.labs.nic.cz/labs/bird/commit/ef8c45749c82e246d477ea4d7f749668... -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
participants (2)
-
mikma.bird＠lists.m7n.se -
Ondrej Zajicek