dump size in bgp_log_error()
bgp_log_error() in proto/bgp/packets.c attempts to dump the message received from the neighbor, in this case containing the BGP attribute considered invalid: bird[681]: PEERNAME: Received: Malformed AS_PATH: 40021a020600001b1b00008b0e00008b but the hex dump is limited to 16 characters and this makes impossible to know exactly what the neighbor is complaining about: if (len > 16) len = 16; It makes sense to limit the size of log messages, but please make the limit much higher because I am sure that we can all spare the space. -- ciao, Marco
On Fri, Dec 01, 2023 at 11:17:50AM +0100, Marco d'Itri wrote:
bgp_log_error() in proto/bgp/packets.c attempts to dump the message received from the neighbor, in this case containing the BGP attribute considered invalid:
bird[681]: PEERNAME: Received: Malformed AS_PATH: 40021a020600001b1b00008b0e00008b
but the hex dump is limited to 16 characters and this makes impossible to know exactly what the neighbor is complaining about:
if (len > 16) len = 16;
It makes sense to limit the size of log messages, but please make the limit much higher because I am sure that we can all spare the space.
Hi You are right, 16 is too low. Will fix that. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) "To err is human -- to blame it on a computer is even more so."
participants (2)
-
Marco d'Itri -
Ondrej Zajicek