Haven't seen any action on this patch, forgotten? http://marc.info/?l=bird-users&m=127200916013140&w=2
On Mon, Apr 26, 2010 at 12:49:32AM +0200, Joakim Tjernlund wrote:
Haven't seen any action on this patch, forgotten?
I missed this patch. Shouldn't autoconf also set linker binary name to some variable (for crosscompiling)? -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Ondrej Zajicek <santiago@crfreenet.org> wrote on 2010/04/26 10:33:20:
On Mon, Apr 26, 2010 at 12:49:32AM +0200, Joakim Tjernlund wrote:
Haven't seen any action on this patch, forgotten?
I missed this patch. Shouldn't autoconf also set linker binary name to some variable (for crosscompiling)?
You would think that, but you need libtool for that. It is better not to use LD directly if you can avoid it. Jocke
On Mon, Apr 26, 2010 at 10:31:18AM +0200, Joakim Tjernlund wrote:
I missed this patch. Shouldn't autoconf also set linker binary name to some variable (for crosscompiling)?
You would think that, but you need libtool for that. It is better not to use LD directly if you can avoid it.
Although i don't like the patch, i can't find a better way to fix this so i will probably merge that. MJ, do you have some comment on this [*]? [*] http://marc.info/?l=bird-users&m=127200916013140&w=2 -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Hello!
Although i don't like the patch, i can't find a better way to fix this so i will probably merge that.
MJ, do you have some comment on this [*]?
I am getting Internal Server Error at this URL now. Do I guess correctly that it is the patch changing calls of ld to calls of cc? I suspect that "-nostdlib" and "-Wl" are much less portable than the previous construct with ld (they look like GCCisms to me). Joakim, have you investigated that? Have a nice fortnight -- Martin `MJ' Mares <mj@ucw.cz> http://mj.ucw.cz/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth System going down at 5 pm to install scheduler bug.
Martin Mares <mj@ucw.cz> wrote on 2010/04/27 22:29:21:
Hello!
Although i don't like the patch, i can't find a better way to fix this so i will probably merge that.
MJ, do you have some comment on this [*]?
I am getting Internal Server Error at this URL now. Do I guess correctly that it is the patch changing calls of ld to calls of cc?
I suspect that "-nostdlib" and "-Wl" are much less portable than the previous construct with ld (they look like GCCisms to me). Joakim, have you investigated that?
No, when I looked at the configure.in it seemed like you already require gcc so I stopped there. -Wl can be changed to -Xlinker(or similar), dunno if that is more portable though. Jocke
On Tue, Apr 27, 2010 at 10:29:21PM +0200, Martin Mares wrote:
Hello!
Although i don't like the patch, i can't find a better way to fix this so i will probably merge that.
MJ, do you have some comment on this [*]?
I am getting Internal Server Error at this URL now. Do I guess correctly that it is the patch changing calls of ld to calls of cc?
diff --git a/tools/Rules.in b/tools/Rules.in index 79a15fa..e4598e2 100644 --- a/tools/Rules.in +++ b/tools/Rules.in @@ -66,7 +66,7 @@ else subdir: all.o all.o: $(objs) - $(LD) -r -o $@ $^ + $(CC) -nostdlib -Wl,-r -o $@ $^
I suspect that "-nostdlib" and "-Wl" are much less portable than the previous construct with ld (they look like GCCisms to me). Joakim, have you investigated that?
This is no issue, we already require GCC. -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Hello!
This is no issue, we already require GCC.
If so, then ACK from me. (BTW where we rely on GCC?) Have a nice fortnight -- Martin `MJ' Mares <mj@ucw.cz> http://mj.ucw.cz/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth "In accord to UNIX philosophy, PERL gives you enough rope to hang yourself." -- Larry Wall
On Tue, Apr 27, 2010 at 10:58:39PM +0200, Martin Mares wrote:
(BTW where we rely on GCC?)
There are several frequent GCCisms in the code, like 'struct abc b = {field: 123}', '? :' or ({ ... }). -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
participants (3)
-
Joakim Tjernlund -
Martin Mares -
Ondrej Zajicek