Pending bird patches and discussions for proto/babel
Hello birds, I just thought I'd put together an overview of as yet unresolved proto/babel patches and discussions to stimulate some activity :) Toke's RTT series: - lib/timer: Add current_time_now() function for immediate timestamp - babel: Add support for the RTT extension - babel: Add route metric smoothing My route selection revamp: - [v5] Babel: Replace internal route selection by bird's nest - [DRAFT] Babel: Implement route daming with fixed delay (s/daming/damping/) Toke's first two patches are ready for merging, but the third (metric smoothing) is contested since it conflicts with my route selection patch in its current form and if adapted it conflicts with my scalability goals for babel instead. Possibly premature optimization admittedly ;) Initially Toke was playing with the idea of exposing the smoothed metric to route filters in a followup patch. Me and Juliusz oppose this, for different reasons and the consensus is to not do that. My stance is that we could choose to merge smoothing as long as we don't expose it's implementation internals (the smoothed metric) to users. This way we can replace it with a more performant approach later. That being said since RTT metric is a new feature anyway I would prefer we just go with my route damping approach, mark RTT as experimental and get some more wider testing through a released version. Lastly my v5 route selection patch should also be ready, all threads of discussion should be resolved and there are no known bugs. However I've not received any testing reports, hint, hint peeps °>° --Daniel
Hello Daniel! On 6/1/23 17:10, Daniel Gröber wrote:
Hello birds,
I just thought I'd put together an overview of as yet unresolved proto/babel patches and discussions to stimulate some activity :)
Toke's RTT series:
- lib/timer: Add current_time_now() function for immediate timestamp - babel: Add support for the RTT extension - babel: Add route metric smoothing
My route selection revamp:
- [v5] Babel: Replace internal route selection by bird's nest - [DRAFT] Babel: Implement route daming with fixed delay (s/daming/damping/)
Toke's first two patches are ready for merging, but the third (metric smoothing) is contested since it conflicts with my route selection patch in its current form and if adapted it conflicts with my scalability goals for babel instead. Possibly premature optimization admittedly ;)
We generally thought that the patches were still kinda work in progress, sorry if our non-responsivity could be interpreted as negligence.
Initially Toke was playing with the idea of exposing the smoothed metric to route filters in a followup patch. Me and Juliusz oppose this, for different reasons and the consensus is to not do that.
My stance is that we could choose to merge smoothing as long as we don't expose it's implementation internals (the smoothed metric) to users. This way we can replace it with a more performant approach later.
That being said since RTT metric is a new feature anyway I would prefer we just go with my route damping approach, mark RTT as experimental and get some more wider testing through a released version. That looks like a feasible way to go. Shall we then just try to merge these patches as they have been sent to the list? Lastly my v5 route selection patch should also be ready, all threads of discussion should be resolved and there are no known bugs. However I've not received any testing reports, hint, hint peeps °>°
OK, will look at it as well. Please send me an owl, a pigeon or another avian carrier compatible with RFC 1149 if we don't react in a reasonable time (est. a fortnight). Thank you for improving Babel implementation in BIRD. We deeply appreciate it. Maria -- Maria Matejka | BIRD Team Leader | CZ.NIC, z.s.p.o.
Hi Maria, On Thu, Jun 01, 2023 at 05:33:42PM +0200, Maria Matejka via Bird-users wrote:
Toke's first two patches are ready for merging, but the third (metric smoothing) is contested since it conflicts with my route selection patch in its current form and if adapted it conflicts with my scalability goals for babel instead. Possibly premature optimization admittedly ;)
We generally thought that the patches were still kinda work in progress, sorry if our non-responsivity could be interpreted as negligence.
No worries, I figured that's what was going on.
That being said since RTT metric is a new feature anyway I would prefer we just go with my route damping approach, mark RTT as experimental and get some more wider testing through a released version.
That looks like a feasible way to go. Shall we then just try to merge these patches as they have been sent to the list?
I have some more changes to make to the dampening patch, but if we're in agreement that this direction is the way to go I'll get a v1 out ASAP. You can merge Toke's patches independently of that though. RTT without smoothing is still useful :)
Lastly my v5 route selection patch should also be ready, all threads of discussion should be resolved and there are no known bugs. However I've not received any testing reports, hint, hint peeps °>°
OK, will look at it as well. Please send me an owl, a pigeon or another avian carrier compatible with RFC 1149 if we don't react in a reasonable time (est. a fortnight).
I'm afraid quality-of-life concerns for the carriers involved prevent this as a method of delivery. Perhaps once RFC 7511 is more widely deployed? I'd be open to sending a reminder mail over conflcit-free silica transmission line though :D Chirp-chirp, --Daniel
Daniel Gröber <dxld@darkboxed.org> writes:
Hi Maria,
On Thu, Jun 01, 2023 at 05:33:42PM +0200, Maria Matejka via Bird-users wrote:
Toke's first two patches are ready for merging, but the third (metric smoothing) is contested since it conflicts with my route selection patch in its current form and if adapted it conflicts with my scalability goals for babel instead. Possibly premature optimization admittedly ;)
We generally thought that the patches were still kinda work in progress, sorry if our non-responsivity could be interpreted as negligence.
No worries, I figured that's what was going on.
That being said since RTT metric is a new feature anyway I would prefer we just go with my route damping approach, mark RTT as experimental and get some more wider testing through a released version.
That looks like a feasible way to go. Shall we then just try to merge these patches as they have been sent to the list?
I have some more changes to make to the dampening patch, but if we're in agreement that this direction is the way to go I'll get a v1 out ASAP.
You can merge Toke's patches independently of that though. RTT without smoothing is still useful :)
Yeah, I'm OK with just merging patches 1-2 of the 3-patch series I sent back in March :) -Toke
On Thu, Jun 01, 2023 at 11:21:36PM +0200, Toke Høiland-Jørgensen via Bird-users wrote:
I have some more changes to make to the dampening patch, but if we're in agreement that this direction is the way to go I'll get a v1 out ASAP.
You can merge Toke's patches independently of that though. RTT without smoothing is still useful :)
Yeah, I'm OK with just merging patches 1-2 of the 3-patch series I sent back in March :)
Thanks, merged. (I just moved current_time_now() to sys/unix due to formal reasons.) -- Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) "To err is human -- to blame it on a computer is even more so."
Ondrej Zajicek <santiago@crfreenet.org> writes:
On Thu, Jun 01, 2023 at 11:21:36PM +0200, Toke Høiland-Jørgensen via Bird-users wrote:
I have some more changes to make to the dampening patch, but if we're in agreement that this direction is the way to go I'll get a v1 out ASAP.
You can merge Toke's patches independently of that though. RTT without smoothing is still useful :)
Yeah, I'm OK with just merging patches 1-2 of the 3-patch series I sent back in March :)
Thanks, merged.
Awesome, thanks!
(I just moved current_time_now() to sys/unix due to formal reasons.)
OK, no objection to that, obviously :) -Toke
Hi Maria, On Thu, Jun 01, 2023 at 05:33:42PM +0200, Maria Matejka via Bird-users wrote:
Lastly my v5 route selection patch should also be ready, all threads of discussion should be resolved and there are no known bugs. However I've not received any testing reports, hint, hint peeps °>°
OK, will look at it as well. Please send me an owl, a pigeon or another avian carrier compatible with RFC 1149 if we don't react in a reasonable time (est. a fortnight).
Just a reminder on this :) --Daniel
Hi Maria, On Tue, Jul 18, 2023 at 12:28:35AM +0200, Daniel Gröber wrote:
On Thu, Jun 01, 2023 at 05:33:42PM +0200, Maria Matejka via Bird-users wrote:
Lastly my v5 route selection patch should also be ready, all threads of discussion should be resolved and there are no known bugs. However I've not received any testing reports, hint, hint peeps °>°
OK, will look at it as well. Please send me an owl, a pigeon or another avian carrier compatible with RFC 1149 if we don't react in a reasonable time (est. a fortnight).
Just a reminder on this :)
I humbly beseech thee to consider deinself reminded again :3 --Daniel
Lastly my v5 route selection patch should also be ready, all threads of discussion should be resolved and there are no known bugs. However I've not received any testing reports, hint, hint peeps °>° OK, will look at it as well. Please send me an owl, a pigeon or another avian carrier compatible with RFC 1149 if we don't react in a reasonable time (est. a fortnight). Just a reminder on this :) I humbly beseech thee to consider deinself reminded again :3
Oopsie, obviously got distracted by something else. Will check and possibly merge in several days, hopefully. Sorry for that. Maria -- Maria Matejka (she/her) | BIRD Team Leader | CZ.NIC, z.s.p.o.
participants (4)
-
Daniel Gröber -
Maria Matejka -
Ondrej Zajicek -
Toke Høiland-Jørgensen