interface name bug under *BSD?
Hi, I'm running FreeBSD 8.1 and started using Bird 1.2.5 for the first time today, but it kept finding interfaces with garbled names, eg. Jan 7 20:10:23 <daemon.debug> soek bird: WUG < interface bridge0^B^KM- \xf8L\xf8 goes up Jan 7 20:10:23 <daemon.debug> soek bird: WUG < primary address 172.18.87.128/28 on interface bridge0^B^KM- \xf8L\xf8 added On closer inspection I think I've discovered a problem in sysdep/bsd/krt-sock.c in that it fails to use dl->sdl_nlen when extracting the interface name from dl->sdl_data. According to <net/if_dl.h> the interface name in sdl_data does not require null termination. Possible patch attached. Could someone review this please? Thanks, Aragon
On Fri, Jan 07, 2011 at 11:31:36PM +0200, Aragon Gouveia wrote:
Hi,
I'm running FreeBSD 8.1 and started using Bird 1.2.5 for the first time today, but it kept finding interfaces with garbled names, eg.
Possible patch attached. Could someone review this please?
Thanks for the patch, it is fine. I already fixed this bug (reported by bird@hkbsd.com). -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
participants (2)
-
Aragon Gouveia -
Ondrej Zajicek