[ The first email does not come, resending. Is there some problem with mailing list? ] Hello First patch fixes bug causing reconfigure completely not work on OSPF. Second patch fixes endianity problem in debug message. Next three patches are from Debian package of bird. Maybe you already know them. The last one is needed to be able to compile bird on recent system, it is rather large, so i do not attached it. it is here: ftp://varda.crfreenet.org/users/santiago/misc/000_update_config_guess_sub.patch -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Hi!
First patch fixes bug causing reconfigure completely not work on OSPF.
Second patch fixes endianity problem in debug message.
Feela, are these OK?
Next three patches are from Debian package of bird. Maybe you already know them. The last one is needed to be able to compile bird on recent system, it is rather large, so i do not attached it. it is here:
ftp://varda.crfreenet.org/users/santiago/misc/000_update_config_guess_sub.patch
Updating config.{guess,sub} should definitely not do any harm. Applied.
diff -urN bird-1.0.11.orig/client/client.c bird-1.0.11/client/client.c --- bird-1.0.11.orig/client/client.c 2004-06-05 05:26:48.000000000 -0400 +++ bird-1.0.11/client/client.c 2006-07-13 09:34:04.000000000 -0400 @@ -254,7 +254,7 @@ die("Cannot create socket: %m"); bzero(&sa, sizeof(sa)); sa.sun_family = AF_UNIX; - strcpy(sa.sun_path, server_path); + strncpy(sa.sun_path, server_path, sizeof(sa.sun_path)); if (connect(server_fd, (struct sockaddr *) &sa, SUN_LEN(&sa)) < 0) die("Unable to connect to server control socket (%s): %m", server_path); if (fcntl(server_fd, F_SETFL, O_NONBLOCK) < 0) diff -urN bird-1.0.11.orig/sysdep/unix/io.c bird-1.0.11/sysdep/unix/io.c --- bird-1.0.11.orig/sysdep/unix/io.c 2005-02-14 18:15:04.000000000 -0500 +++ bird-1.0.11/sysdep/unix/io.c 2006-07-13 09:34:29.000000000 -0400 @@ -866,7 +866,7 @@ goto bad; unlink(name); sa.sun_family = AF_UNIX; - strcpy(sa.sun_path, name); + strncpy(sa.sun_path, name, sizeof(sa.sun_path)); if (bind(fd, (struct sockaddr *) &sa, SUN_LEN(&sa)) < 0) ERR("bind"); if (listen(fd, 8))
This is seriously wrong. If the name is too long, it gets trimmed and the terminating zero gets lost. The proper solution would be to report an error in such cases. Could you please update the patch?
diff -urN bird-1.0.11.orig/conf/Makefile bird-1.0.11/conf/Makefile --- bird-1.0.11.orig/conf/Makefile 2000-03-12 18:04:04.000000000 -0500 +++ bird-1.0.11/conf/Makefile 2006-07-13 10:30:06.000000000 -0400 @@ -24,6 +24,6 @@ $(M4) -P $(conf-src)/gen_commands.m4 $(srcdir)/client/cmds.m4 $(conf-fragments) | sort >commands.h
cf-lex.c: cf-lex.l - $(FLEX) $(FLEX_DEBUG) -sB8 -ocf-lex.c -Pcf_ cf-lex.l + $(FLEX) $(FLEX_DEBUG) -s -B -8 -ocf-lex.c -Pcf_ cf-lex.l
depend: keywords.h commands.h cf-parse.tab.c cf-lex.c
This is already present in our repository. BTW, would anybody object to converting the CVS repository to GIT and making it available for read-only access to everybody? Have a nice fortnight -- Martin `MJ' Mares <mj@ucw.cz> http://mj.ucw.cz/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
Martin Mares wrote:
Hi!
First patch fixes bug causing reconfigure completely not work on OSPF.
Second patch fixes endianity problem in debug message.
Feela, are these OK?
Yes. I applied them. [...]
BTW, would anybody object to converting the CVS repository to GIT and making it available for read-only access to everybody?
As we are just two active members of the bird team and I do not object, go for it. :-) Ondrej
Have a nice fortnight
Hello On Mon, Aug 25, 2008 at 01:12:07PM +0200, Martin Mares wrote:
diff -urN bird-1.0.11.orig/sysdep/unix/io.c bird-1.0.11/sysdep/unix/io.c --- bird-1.0.11.orig/sysdep/unix/io.c 2005-02-14 18:15:04.000000000 -0500 +++ bird-1.0.11/sysdep/unix/io.c 2006-07-13 09:34:29.000000000 -0400 @@ -866,7 +866,7 @@ goto bad; unlink(name); sa.sun_family = AF_UNIX; - strcpy(sa.sun_path, name); + strncpy(sa.sun_path, name, sizeof(sa.sun_path)); if (bind(fd, (struct sockaddr *) &sa, SUN_LEN(&sa)) < 0) ERR("bind"); if (listen(fd, 8))
This is seriously wrong. If the name is too long, it gets trimmed and the terminating zero gets lost. The proper solution would be to report an error in such cases. Could you please update the patch?
As O. Filip already has some variant of the patch in his tree, i will postpone this until i saw that. The public GIT repository would be nice. -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
Hi!
As O. Filip already has some variant of the patch in his tree, i will postpone this until i saw that.
Ondra has applied the patch exactly as you have send it, but once he read my comment, he has reverted it. Have a nice fortnight -- Martin `MJ' Mares <mj@ucw.cz> http://mj.ucw.cz/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth This message is transmitted on 100% recycled electrons.
On Mon, Aug 25, 2008 at 01:12:07PM +0200, Martin Mares wrote:
BTW, would anybody object to converting the CVS repository to GIT and making it available for read-only access to everybody?
That would be nice. Does all this recent activity means that development for bird will continue? -otto
Hello!
Does all this recent activity means that development for bird will continue?
Well, it is hard to tell what it means :-) I certainly do not have time for writing any new code to BIRD and Feela seems to be in the exactly same situation. However, both of us are interested in fixing bugs and reviewing and applying patches sent by other people. If there is anybody who has more time than we do and who is interested in working on BIRD, we certainly could pass the maintainership to him. Have a nice fortnight -- Martin `MJ' Mares <mj@ucw.cz> http://mj.ucw.cz/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth "One single semicolon. A perfect drop of perliness. The rest is padding." -- S. Manandhar
Otto Solares wrote:
On Mon, Aug 25, 2008 at 01:12:07PM +0200, Martin Mares wrote:
BTW, would anybody object to converting the CVS repository to GIT and making it available for read-only access to everybody?
That would be nice.
Does all this recent activity means that development for bird will continue?
Yes, but quite slowly. I have a set of patches for BGP. I have not test them yet. And I am preparing on a testing environment for me to have faster responses. :-) And of course my very long long term plan is to rewrite RIP and implement OSPFv3. Do you have some feature request? Ondrej
-otto
On Mon, Aug 25, 2008 at 09:28:34PM +0200, Ondrej Filip wrote:
Otto Solares wrote:
On Mon, Aug 25, 2008 at 01:12:07PM +0200, Martin Mares wrote:
BTW, would anybody object to converting the CVS repository to GIT and making it available for read-only access to everybody?
That would be nice.
Does all this recent activity means that development for bird will continue?
Yes, but quite slowly. I have a set of patches for BGP. I have not test them yet. And I am preparing on a testing environment for me to have faster responses. :-)
Excellent!
And of course my very long long term plan is to rewrite RIP and implement OSPFv3.
Do you have some feature request?
MD5 connections for BGP is the only thing missing for me now that is supported upstream in the kernel. I'm currently using Bird in Debian Etch with a 2.6.26.3 kernel and it works perfectly, the killer app is the multiple kernel tables support, altough I just use it for BGP (global + Internet2 huge tables + IPv6). Thanks, -otto
Otto Solares wrote:
On Mon, Aug 25, 2008 at 09:28:34PM +0200, Ondrej Filip wrote:
Otto Solares wrote:
On Mon, Aug 25, 2008 at 01:12:07PM +0200, Martin Mares wrote:
BTW, would anybody object to converting the CVS repository to GIT and making it available for read-only access to everybody? That would be nice.
Does all this recent activity means that development for bird will continue? Yes, but quite slowly. I have a set of patches for BGP. I have not test them yet. And I am preparing on a testing environment for me to have faster responses. :-)
Excellent!
And of course my very long long term plan is to rewrite RIP and implement OSPFv3.
Do you have some feature request?
MD5 connections for BGP is the only thing missing for me now that is supported upstream in the kernel.
Well, I have the code ready. It was written by one student a part of his thesis. But since it was not tested properly, I am waiting for the test bed setup. So I hope, I will include it quite soon (means 1 month or so).
I'm currently using Bird in Debian Etch with a 2.6.26.3 kernel and it works perfectly, the killer app is the multiple kernel tables support, altough I just use it for BGP (global + Internet2 huge tables + IPv6).
Don't you have any issues with stability? Ondrej
Thanks,
-otto
On Mon, Aug 25, 2008 at 09:45:53PM +0200, Ondrej Filip wrote:
Otto Solares wrote:
On Mon, Aug 25, 2008 at 09:28:34PM +0200, Ondrej Filip wrote:
Otto Solares wrote:
On Mon, Aug 25, 2008 at 01:12:07PM +0200, Martin Mares wrote:
BTW, would anybody object to converting the CVS repository to GIT and making it available for read-only access to everybody? That would be nice.
Does all this recent activity means that development for bird will continue? Yes, but quite slowly. I have a set of patches for BGP. I have not test them yet. And I am preparing on a testing environment for me to have faster responses. :-)
Excellent!
And of course my very long long term plan is to rewrite RIP and implement OSPFv3.
Do you have some feature request?
MD5 connections for BGP is the only thing missing for me now that is supported upstream in the kernel.
Well, I have the code ready. It was written by one student a part of his thesis. But since it was not tested properly, I am waiting for the test bed setup. So I hope, I will include it quite soon (means 1 month or so).
Don't forget to announce to the ML as I don't track bird repositories (or I'm not aware of it existance).
I'm currently using Bird in Debian Etch with a 2.6.26.3 kernel and it works perfectly, the killer app is the multiple kernel tables support, altough I just use it for BGP (global + Internet2 huge tables + IPv6).
Don't you have any issues with stability?
Now is very stable for like a year, in the early testing when I was migrating from Quagga I had a lot of segfaults and issues which I corrected with the patches I post to the debian bugs and with the attached hacks. -otto
Ondrej Zajicek wrote:
[ The first email does not come, resending. Is there some problem with mailing list? ]
It seems to be. :-(
Hello
First patch fixes bug causing reconfigure completely not work on OSPF.
Already in CVS.
Second patch fixes endianity problem in debug message.
Applied.
Next three patches are from Debian package of bird. Maybe you already know them. The last one is needed to be able to compile bird on recent system, it is rather large, so i do not attached it. it is here:
Applied or already in CVS. Thank you! Ondrej
ftp://varda.crfreenet.org/users/santiago/misc/000_update_config_guess_sub.patch
participants (4)
-
Martin Mares -
Ondrej Filip -
Ondrej Zajicek -
Otto Solares