[PATCH] Nest: Read Babel metric as IGP metric
Hi all, When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel metrics are not read as an IGP metric for BGP purposes. I've attached a simple patch that adds this support - it seems to do the trick in my local testing. Best, James
Shouldn't that be done in Gitlab / Source Code repo? On 16/08/2020 23.58, James Lu wrote:
Hi all,
When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel metrics are not read as an IGP metric for BGP purposes. I've attached a simple patch that adds this support - it seems to do the trick in my local testing.
Best, James
-- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
I'm honestly not too sure. AFAICT, the repo[1][2] points to the mailing list as the preferred point of contact. [1]: https://gitlab.nic.cz/labs/bird/-/blob/master/README#L65-72 [2]: https://gitlab.nic.cz/labs/bird/-/merge_requests/24#note_73422 On 2020-08-16 2:10 p.m., Skyler Mäntysaari wrote:
Shouldn't that be done in Gitlab / Source Code repo?
On 16/08/2020 23.58, James Lu wrote:
Hi all,
When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel metrics are not read as an IGP metric for BGP purposes. I've attached a simple patch that adds this support - it seems to do the trick in my local testing.
Best, James
Ah, I seem to be corrected. Never mind me then. On 17/08/2020 0.18, James Lu wrote:
I'm honestly not too sure. AFAICT, the repo[1][2] points to the mailing list as the preferred point of contact.
[1]: https://gitlab.nic.cz/labs/bird/-/blob/master/README#L65-72 [2]: https://gitlab.nic.cz/labs/bird/-/merge_requests/24#note_73422
On 2020-08-16 2:10 p.m., Skyler Mäntysaari wrote:
Shouldn't that be done in Gitlab / Source Code repo?
On 16/08/2020 23.58, James Lu wrote:
Hi all,
When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel metrics are not read as an IGP metric for BGP purposes. I've attached a simple patch that adds this support - it seems to do the trick in my local testing.
Best, James
James Lu <james@overdrivenetworks.com> writes:
Hi all,
When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel metrics are not read as an IGP metric for BGP purposes. I've attached a simple patch that adds this support - it seems to do the trick in my local testing.
Yeah, this seems reasonable! Acked-by: Toke Høiland-Jørgensen <toke@toke.dk> Out of curiosity, what setup are you using Babel+BGP for where you need this? :) -Toke
Ah, this isn't for anything too serious. It's just a setup for dn42 I'm testing out right now. Best, James On 2020-08-17 1:37 a.m., Toke Høiland-Jørgensen wrote:
James Lu <james@overdrivenetworks.com> writes:
Hi all,
When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel metrics are not read as an IGP metric for BGP purposes. I've attached a simple patch that adds this support - it seems to do the trick in my local testing.
Yeah, this seems reasonable!
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Out of curiosity, what setup are you using Babel+BGP for where you need this? :)
-Toke
Hello, Can someone take a look at this? It's a pretty simple patch but a patch nonetheless, so it'd be great if this was fixed upstream. Best, James On 2020-08-16 1:58 p.m., James Lu wrote:
Hi all,
When testing Babel with Bird 2.0.7, I noticed that unlike OSPF, Babel metrics are not read as an IGP metric for BGP purposes. I've attached a simple patch that adds this support - it seems to do the trick in my local testing.
Best, James
On Mon, Dec 28, 2020 at 05:05:07PM -0800, James Lu wrote:
Hello,
Can someone take a look at this? It's a pretty simple patch but a patch nonetheless, so it'd be great if this was fixed upstream.
Hello Thanks, merged [*]. Sorry, forgot about that. [*] https://gitlab.nic.cz/labs/bird/-/commit/455c13dc9971ae4aa701135b5c1709d6147... -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
participants (4)
-
James Lu -
Ondrej Zajicek -
Skyler Mäntysaari -
Toke Høiland-Jørgensen