A bug in patch from FreeBSD ports
Hello There is a patch for BIRD in FreeBSD ports that causes OSPF crash: https://svnweb.freebsd.org/ports?view=revision&revision=484648 22 + if (en->lsa_body && (en->lsa.age == LSA_MAXAGE)) 23 + { 24 + /* en could be an unexpected self-originated lsa in which case nf is NULL */ 25 + log(L_INFO "%s: Found flushing LSA while originating %I/%d with fib: %p", 26 + p->p.name, lsa->nf->fn.prefix, lsa->nf->fn.pxlen, en->nf); 27 + en->nf = lsa->nf; 28 + } 29 lsa->nf here may be NULL. I would suggest to send BIRD patches for review to the BIRD mailing list so we can review it and also merge it upstream. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
On Mon, Aug 26, 2019 at 07:39:32PM +0200, Ondrej Zajicek wrote:
Hello
There is a patch for BIRD in FreeBSD ports that causes OSPF crash:
... I would suggest to send BIRD patches for review to the BIRD mailing list so we can review it and also merge it upstream.
Just found that the patch was sent to BIRD mailing list, i missed the bug, but instead proposed a different fix, which got merged. So the patch is unnecessary. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
On Mon, Aug 26, 2019 at 11:56 AM Ondrej Zajicek <santiago@crfreenet.org> wrote:
Just found that the patch was sent to BIRD mailing list, i missed the bug, but instead proposed a different fix, which got merged. So the patch is unnecessary.
Sorry for the disturbance, the port was updated accordingly: https://svnweb.freebsd.org/ports?view=revision&revision=510039
participants (2)
-
Olivier Cochard-Labbé -
Ondrej Zajicek