BGP "missing lladdr" option not implemented?
Hi, I was looking at the "missing lladdr" options under BGP Channel configuration, but I can't find how it is implemented in the code. It seems to me that the only use of the missing_lladdr field in struct bgp_channel_config is in the configuration parser, bgp_postconfig to set its default value, and bgp_channel_reconfigure. I think it is like this since this particular commit : commit d15b0b0a1b494c14b139d2d28706d82cd6e2f139 Author: Ondrej Zajicek (work) <santiago@crfreenet.org> Date: Wed Dec 7 14:11:28 2016 +0100 BGP redesign Integrated and extensible BGP with generalized AFI handling, support for IPv4+IPv6 AFI and unicast+multicast SAFI. Was that intended or did I miss something? Thanks, Sébastien
On Thu, Dec 10, 2020 at 05:19:24PM +0100, Sébastien Parisot wrote:
Hi,
I was looking at the "missing lladdr" options under BGP Channel configuration, but I can't find how it is implemented in the code. It seems to me that the only use of the missing_lladdr field in struct bgp_channel_config is in the configuration parser, bgp_postconfig to set its default value, and bgp_channel_reconfigure.
...
Was that intended or did I miss something?
Hi (Noticed while looking for some missed / forgotten e-mails) Yes, 'missing lladdr' option is intentionally deprecated/ignored. We just forgot to remove it from doc and some parts of code. Fixed here: https://gitlab.nic.cz/labs/bird/-/commit/4155104c90bc2f3fb680e8041e079ceb3d8... -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
participants (2)
-
Ondrej Zajicek -
Sébastien Parisot