Hello list! Currently tools/Makefile.in explicitly strips every binary it installs via '$(INSTALL_PROGRAM) -s'. Usually INSTALL_PROGRAM already has '-s' set (unless user specified he wants unstripped binary) Can we please remove the second '-s' ? P.S. IIRC this was already discussed but I can't find it.
On Thu, Aug 01, 2013 at 08:54:00PM +0400, Alexander V. Chernikov wrote:
Hello list!
Currently tools/Makefile.in explicitly strips every binary it installs via '$(INSTALL_PROGRAM) -s'. Usually INSTALL_PROGRAM already has '-s' set (unless user specified he wants unstripped binary)
Well, AFAIK INSTALL_PROGRAM do not have '-s' by default (at least not on my system and also according to Autoconf documentation). But as both GNU coding standards and FreeBSD Porter's Handbook say that 'make install' shouldn't strip binaries by default, i will apply the patch. -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."
On Fri, 02 Aug 2013, Ondrej Zajicek wrote:
On Thu, Aug 01, 2013 at 08:54:00PM +0400, Alexander V. Chernikov wrote:
Currently tools/Makefile.in explicitly strips every binary it installs via '$(INSTALL_PROGRAM) -s'. Usually INSTALL_PROGRAM already has '-s' set (unless user specified he wants unstripped binary)
Well, AFAIK INSTALL_PROGRAM do not have '-s' by default (at least not on my system and also according to Autoconf documentation).
But as both GNU coding standards and FreeBSD Porter's Handbook say that 'make install' shouldn't strip binaries by default, i will apply the patch.
The coding standards say that because any decent distro will strip symbols from the regular binary packages, and keep them for the debug packages. If you strip them upstream, we have to patch the build system to get rid of that. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
participants (3)
-
Alexander V. Chernikov -
Henrique de Moraes Holschuh -
Ondrej Zajicek