Debian armel test fail blocking transition to testing
Hello, bird-2.0.10 builds fine on most of Debian archs, but on armel, hppa, and riscv64 there is a failing test: obj/filter/trie_test: t_trie_walk: Timeout expired obj/filter/trie_test: t_trie_walk 5.010453063s [FAIL] obj/filter/trie_test 12.572917503s [FAIL] make[1]: *** [Makefile:180: obj/filter/trie_test.ok] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/<<PKGBUILDDIR>>' dh_auto_test: error: make -j4 test "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1 returned exit code 2 make: *** [debian/rules:21: build-arch] Error 25 Nice overview including log tails here: https://buildd.debian.org/status/package.php?p=bird2 As these tests are run as part of build, failing tests result in FTBFS and armel FTBFS is blocking transition to testing as seen here: https://tracker.debian.org/pkg/bird2 armel refers to older ARM 32-bit HW - if you have access to the arch, could you please test/fix this? Cheers, Jakub Ružička
Hello! On 6/28/22 1:42 PM, Jakub Ružička wrote:
Hello,
bird-2.0.10 builds fine on most of Debian archs, but on armel, hppa, and riscv64 there is a failing test:
obj/filter/trie_test: t_trie_walk: Timeout expired obj/filter/trie_test: t_trie_walk 5.010453063s [FAIL] obj/filter/trie_test 12.572917503s [FAIL] make[1]: *** [Makefile:180: obj/filter/trie_test.ok] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/<<PKGBUILDDIR>>' dh_auto_test: error: make -j4 test "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1 returned exit code 2 make: *** [debian/rules:21: build-arch] Error 25
Are these build machines physical or virtual? I would suppose that the trie walk test just times out due to too tight test timeouts. It takes 3 seconds on my laptop. Are you ok with trying to push a version where these timeouts would be set to 60 seconds instead of 5? Thanks Maria
It's not first time build failed (due to similar error), see https://buildd.debian.org/status/logs.php?pkg=bird2&arch=armel for example. Increasing BT_TIMEOUT in test/birdtest.h might help. - Daniel On 6/28/22 14:03, Maria Matejka wrote:
Hello!
On 6/28/22 1:42 PM, Jakub Ružička wrote:
Hello,
bird-2.0.10 builds fine on most of Debian archs, but on armel, hppa, and riscv64 there is a failing test:
obj/filter/trie_test: t_trie_walk: Timeout expired obj/filter/trie_test: t_trie_walk 5.010453063s [FAIL] obj/filter/trie_test 12.572917503s [FAIL] make[1]: *** [Makefile:180: obj/filter/trie_test.ok] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/<<PKGBUILDDIR>>' dh_auto_test: error: make -j4 test "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1 returned exit code 2 make: *** [debian/rules:21: build-arch] Error 25
Are these build machines physical or virtual? I would suppose that the trie walk test just times out due to too tight test timeouts. It takes 3 seconds on my laptop.
Are you ok with trying to push a version where these timeouts would be set to 60 seconds instead of 5?
Thanks Maria
Hi, On 28/06/2022 13:03, Maria Matejka wrote:
Hello!
On 6/28/22 1:42 PM, Jakub Ružička wrote:
Hello,
bird-2.0.10 builds fine on most of Debian archs, but on armel, hppa, and riscv64 there is a failing test:
obj/filter/trie_test: t_trie_walk: Timeout expired obj/filter/trie_test: t_trie_walk 5.010453063s [FAIL] obj/filter/trie_test 12.572917503s [FAIL] make[1]: *** [Makefile:180: obj/filter/trie_test.ok] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/<<PKGBUILDDIR>>' dh_auto_test: error: make -j4 test "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1 returned exit code 2 make: *** [debian/rules:21: build-arch] Error 25
Are these build machines physical or virtual? I would suppose that the trie walk test just times out due to too tight test timeouts. It takes 3 seconds on my laptop.
Are you ok with trying to push a version where these timeouts would be set to 60 seconds instead of 5?
I've also had this issue in the past, where the trie tests would time out when building Bird packages for ARM devices. As far as I remember, I was building on bare metal on a Raspberry Pi at the time, and increasing the timeout from 5 to 60 seconds solved the issue on that hardware. I kept this change as a vendor patch in my own tree at the time, given the hardware-dependent nature of how long these tests take to run, but as it seems that multiple people are running into this, it might be worth changing upstream in order to better accommodate slower hardware. Cheers, --mm.
Hey, On 6/28/22 14:03, Maria Matejka wrote:
Hello!
On 6/28/22 1:42 PM, Jakub Ružička wrote:
Hello,
bird-2.0.10 builds fine on most of Debian archs, but on armel, hppa, and riscv64 there is a failing test:
obj/filter/trie_test: t_trie_walk: Timeout expired obj/filter/trie_test: t_trie_walk 5.010453063s [FAIL] obj/filter/trie_test 12.572917503s [FAIL] make[1]: *** [Makefile:180: obj/filter/trie_test.ok] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory '/<<PKGBUILDDIR>>' dh_auto_test: error: make -j4 test "TESTSUITEFLAGS=-j4 --verbose" VERBOSE=1 returned exit code 2 make: *** [debian/rules:21: build-arch] Error 25
Are these build machines physical or virtual? I would suppose that the trie walk test just times out due to too tight test timeouts. It takes 3 seconds on my laptop. I think Debian auto-builders are mostly bare metal machines, but often slow and heavily loaded, so I think it's simply the case of insufficient timeout.
Are you ok with trying to push a version where these timeouts would be set to 60 seconds instead of 5? I've uploaded 2.0.10-2 into unstable with a patch increasing BT_TIMEOUT in test/birdtest.h to 60 as suggested (thanks Daniel for a direct link into the relevant source file).
Looks fixed: https://buildd.debian.org/status/package.php?p=bird2 I suggest including this patch upstream so that people don't have to maintain downstream patches. Cheers, Jakub
participants (4)
-
Daniel Suchy -
Jakub Ružička -
Maria Matejka -
Molly Miller