Does anyone know what happened to this patch/discussion: http://bird.network.cz/pipermail/bird-users/2016-February/010192.html I believe it (or similar) is needed for IPv6 merge paths to work, and I'm interested in that working. Thanks, Neil
Hi Neil, you are correct. You need this patch on top of BIRD 1.6 to have working ECMP for IPv6. This patch is not currently merged, and we did not get any feedback on it so far or an estimate when this will happen. As you see, it's been a few months that it lies around here, so I am not sure this is ever going to happen. If you intend to apply this patch yourself, I'd recommend to use version 2 at least (http://bird.network.cz/pipermail/bird-users/2016-February/010239.html), as it includes some fixes. Having that said, I am aware of at least another issue related to the route scan after an ECMP export, which we fixed internally in v3. In lack of interest, we did not bother to send it upstream so far. However, I will ask Mikhail to send it tomorrow, or I will do, so that other interested folks can at least find it on the list. Greetings, Arno
Thanks Arno; I certainly would appreciate seeing your v3 tomorrow. On Thu, Aug 18, 2016 at 5:39 PM Arno Töll <arno.toell+bird@profitbricks.com> wrote:
Hi Neil,
you are correct. You need this patch on top of BIRD 1.6 to have working ECMP for IPv6. This patch is not currently merged, and we did not get any feedback on it so far or an estimate when this will happen. As you see, it's been a few months that it lies around here, so I am not sure this is ever going to happen. If you intend to apply this patch yourself, I'd recommend to use version 2 at least (http://bird.network.cz/pipermail/bird-users/2016-February/010239.html), as it includes some fixes.
Having that said, I am aware of at least another issue related to the route scan after an ECMP export, which we fixed internally in v3. In lack of interest, we did not bother to send it upstream so far. However, I will ask Mikhail to send it tomorrow, or I will do, so that other interested folks can at least find it on the list.
Greetings, Arno
On Thu, Aug 18, 2016 at 06:39:24PM +0200, Arno Töll wrote:
Having that said, I am aware of at least another issue related to the route scan after an ECMP export, which we fixed internally in v3. In lack of interest, we did not bother to send it upstream so far. However, I will ask Mikhail to send it tomorrow, or I will do, so that other interested folks can at least find it on the list.
Arno, I also wanted to voice interest in this work. I've been testing the v2 patch, and I've encountered the bug you described (the multipath route gets installed initially, but bird subsequently reports a sync error, and the debug log indicates the multipath route is attempting to be reinstalled indefinitely with error). Regards, Michael
Hi Michael, Neil and all, Thanks for you interest in the patch. I'll try to post the updated patch version within the next few days. Mikhail 2016-08-20 2:55 GMT+03:00 Michael Elkins <me@sigpipe.org>:
On Thu, Aug 18, 2016 at 06:39:24PM +0200, Arno Töll wrote:
Having that said, I am aware of at least another issue related to the route scan after an ECMP export, which we fixed internally in v3. In lack of interest, we did not bother to send it upstream so far. However, I will ask Mikhail to send it tomorrow, or I will do, so that other interested folks can at least find it on the list.
Arno,
I also wanted to voice interest in this work. I've been testing the v2 patch, and I've encountered the bug you described (the multipath route gets installed initially, but bird subsequently reports a sync error, and the debug log indicates the multipath route is attempting to be reinstalled indefinitely with error).
Regards,
Michael
Hi Mikhail, I don't want to sound ungrateful, but that sounds a bit odd. Is something stopping you from posting the updated patch immediately? I would really appreciate it today, or as soon as possible after that. Best wishes, Neil On Sun, Aug 21, 2016 at 8:19 PM Mikhail Sennikovskii < mikhail.sennikovskii@profitbricks.com> wrote:
Hi Michael, Neil and all,
Thanks for you interest in the patch. I'll try to post the updated patch version within the next few days.
Mikhail
2016-08-20 2:55 GMT+03:00 Michael Elkins <me@sigpipe.org>:
On Thu, Aug 18, 2016 at 06:39:24PM +0200, Arno Töll wrote:
Having that said, I am aware of at least another issue related to the route scan after an ECMP export, which we fixed internally in v3. In lack of interest, we did not bother to send it upstream so far. However, I will ask Mikhail to send it tomorrow, or I will do, so that other interested folks can at least find it on the list.
Arno,
I also wanted to voice interest in this work. I've been testing the v2 patch, and I've encountered the bug you described (the multipath route gets installed initially, but bird subsequently reports a sync error, and the debug log indicates the multipath route is attempting to be reinstalled indefinitely with error).
Regards,
Michael
I've been looking at v2 of this patch, and have not been able to understand the operation of the for loop in these lines from mpnh_sort: ret = mpnh_copy_lp(x, lp); for (old_prev = x, new_prev = ret; old_prev != prev; old_prev = old_prev->next, new_prev = new_prev->next); I'm probably being stupid - but can someone explain how that for loop works? Thanks, Neil On Mon, Aug 22, 2016 at 11:21 AM Neil Jerram <neil@tigera.io> wrote:
Hi Mikhail,
I don't want to sound ungrateful, but that sounds a bit odd. Is something stopping you from posting the updated patch immediately? I would really appreciate it today, or as soon as possible after that.
Best wishes, Neil
On Sun, Aug 21, 2016 at 8:19 PM Mikhail Sennikovskii < mikhail.sennikovskii@profitbricks.com> wrote:
Hi Michael, Neil and all,
Thanks for you interest in the patch. I'll try to post the updated patch version within the next few days.
Mikhail
2016-08-20 2:55 GMT+03:00 Michael Elkins <me@sigpipe.org>:
On Thu, Aug 18, 2016 at 06:39:24PM +0200, Arno Töll wrote:
Having that said, I am aware of at least another issue related to the route scan after an ECMP export, which we fixed internally in v3. In lack of interest, we did not bother to send it upstream so far. However, I will ask Mikhail to send it tomorrow, or I will do, so that other interested folks can at least find it on the list.
Arno,
I also wanted to voice interest in this work. I've been testing the v2 patch, and I've encountered the bug you described (the multipath route gets installed initially, but bird subsequently reports a sync error, and the debug log indicates the multipath route is attempting to be reinstalled indefinitely with error).
Regards,
Michael
Hi Michael, Neil, Just posted the v3 version of the patch. See http://bird.network.cz/pipermail/bird-users/2016-August/010558.html Regards, Mikhail 2016-08-21 21:00 GMT+02:00 Mikhail Sennikovskii < mikhail.sennikovskii@profitbricks.com>:
Hi Michael, Neil and all,
Thanks for you interest in the patch. I'll try to post the updated patch version within the next few days.
Mikhail
2016-08-20 2:55 GMT+03:00 Michael Elkins <me@sigpipe.org>:
On Thu, Aug 18, 2016 at 06:39:24PM +0200, Arno Töll wrote:
Having that said, I am aware of at least another issue related to the route scan after an ECMP export, which we fixed internally in v3. In lack of interest, we did not bother to send it upstream so far. However, I will ask Mikhail to send it tomorrow, or I will do, so that other interested folks can at least find it on the list.
Arno,
I also wanted to voice interest in this work. I've been testing the v2 patch, and I've encountered the bug you described (the multipath route gets installed initially, but bird subsequently reports a sync error, and the debug log indicates the multipath route is attempting to be reinstalled indefinitely with error).
Regards,
Michael
participants (4)
-
Arno Töll -
Michael Elkins -
Mikhail Sennikovskii -
Neil Jerram