[PATCH] Unix IO: Set socket priority after setting family specific options

Ondrej Zajicek santiago at crfreenet.org
Tue Jan 23 17:30:03 CET 2018


On Mon, Jan 22, 2018 at 10:52:05AM +0100, Vincent Bernat wrote:
> From: Vincent Bernat <vincent at bernat.im>
> 
> On Linux, setting the ToS will also set the priority and the range of
> accepted values is quite limited (masked by 0x1e). Therefore, 0xc0 is
> translated to a priority of 0, not something we want, overriding the
> "7" priority which was set previously explicitely. To avoid that, just
> move setting priority later in the code.

Thanks, merged.

Seems like the Linux behavior is brain-damaged two times at once. First,
it implicitly sets one socket option as a side effect of setting another
socket option, even if the first socket option was set explicitly.
Second, it uses obsolete interpretation of ToS values for that.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."


More information about the Bird-users mailing list