[PATCH] babel: Fix missing modulo comparison of seqnos

Ondrej Zajicek santiago at crfreenet.org
Mon Jan 30 23:54:52 CET 2023


On Mon, Jan 30, 2023 at 11:15:52PM +0100, Toke Høiland-Jørgensen via Bird-users wrote:
> Juliusz noticed there were a couple of places we were doing straight
> inequality comparisons of seqnos in Babel. This is wrong because seqnos can
> wrap: so we need to use the modulo-64k comparison function for these cases
> as well.
> 
> Introduce a strict-inequality version of the modulo-comparison for this
> purpose.

Thanks, merged:

https://gitlab.nic.cz/labs/bird/-/commit/3e7e4a71868bc519aacc0eb785471b46fc345a5c

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."



More information about the Bird-users mailing list