[PATCH] babel: Fix missing modulo comparison of seqnos

Toke Høiland-Jørgensen toke at toke.dk
Tue Jan 31 00:09:21 CET 2023


Ondrej Zajicek <santiago at crfreenet.org> writes:

> On Mon, Jan 30, 2023 at 11:15:52PM +0100, Toke Høiland-Jørgensen via Bird-users wrote:
>> Juliusz noticed there were a couple of places we were doing straight
>> inequality comparisons of seqnos in Babel. This is wrong because seqnos can
>> wrap: so we need to use the modulo-64k comparison function for these cases
>> as well.
>> 
>> Introduce a strict-inequality version of the modulo-comparison for this
>> purpose.
>
> Thanks, merged:
>
> https://gitlab.nic.cz/labs/bird/-/commit/3e7e4a71868bc519aacc0eb785471b46fc345a5c

Uh, that must be a new record turnaround time - thanks! :)

-Toke



More information about the Bird-users mailing list