On Thu, Mar 09, 2017 at 05:36:54PM +0200, Lennert Buytenhek wrote:
Well, the simple way to avoid reconfiguration in this case is just to move 'remote_as2' field at the end of bgp_config, like 'check_link' or 'bfd'.
Well, e.g. if remote_as is 12345 and the currently established peer AS is 12345, and you change remote_as from 12345 to 23456 and remote_as2 from 0 to 12345, you want to avoid doing the reconfigure.
And if you keep remote_as at 12345 and set remote_as2 to 23456 by specifying the ASes the other way around, you would avoid the reconfigure if you leave remote_as2 outside the memcmp() field, but then when the other side completes its maintenance and you reestablish a connection with remote AS 23456, you would then set remote_as from 12345 to 23456 and remote_as2 from 23456 to 0, and that would then unnecessarily trigger a reconfigure as well because remote_as changes.
OK -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."