On Mon, Oct 13, 2008 at 10:18:40PM +0200, Martin Mares wrote:
Hi!
Here is a patch adding support for BGP route reflection.
This is nice, but I would very much prefer having your previous patches integrated first. Could you please fix the problems I have pointed out?
Fixes are attached as patch following bird-md5.diff . Or should i send corrected original patches? 'disable-AS4 per BGP instance' option is not implemented yet, but is on top of my TODO list. BTW, in bgp_rte_better() we compare MEDs between routes from different ASes, although RFC says that MED is only comparable between routes learned from the same neighboring AS. Is this bug or some cleverness?
(Also, please update the documentation to reflect the changes in the code.)
OK -- Elen sila lumenn' omentielvo Ondrej 'SanTiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."