❦ 15 septembre 2016 21:22 CEST, Vincent Bernat <bernat@luffy.cx> :
Thans for the patch. I agree that we should handle the attribute if it has some usage. I have some questions/comments:
Perhaps we should use the same approach like we use for krt_realm? i.e., handle krt_scope as an integer variable and import constants from /etc/iproute2/rt_scopes. So we could handle all values as the Linux kernel and we would be consistent with iproute2 tools.
I didn't know that scope names could be defined in this file. So, yes, we should.
Everything was already in place to use this file. So, the patch is now simplified. While the scope is correctly imported for regular routes, it is not for device routes. I still have to do: protocol direct { table public; import filter { krt_scope = ips_link; accept "ok"; }; interface "eth0*", "eth1*"; } I don't see why, I will investigate more tomorrow. -- Indent to show the logical structure of a program. - The Elements of Programming Style (Kernighan & Plauger)