On Tue, May 30, 2017 at 02:34:17PM +0200, Toke Høiland-Jørgensen wrote:
Ondrej Zajicek <santiago@crfreenet.org> writes:
I see no reason not to do conditional initialization of FIBs in babel_start(). If a channel appears later, it will stay in CS_DOWN until protocol restarts (and FIBs are reinitialized), so you could still just use the presence and CS_UP state of channel and do not need to check for FIB.
Except that the way I implemented things, I just select select the right fib based on address family; so I'll have to litter checks through all of that code just to save a few dozens of bytes of memory... Is that really worth it?
OK, keep them initialized. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."