On Tue, Jul 14, 2015 at 06:33:30AM +0000, Steve Atkinson wrote:
Hi,
This is my first submission into the community, it is a change to the static protocol to support the addition / deletion of static routes based on the availability of the gateway as determined by BFD. This was implemented as a proof of concept for one of our customers, it appears to work although has only been tested against the bfd-beacon, with routes exported to a remote BGP associated router.
Hello Thanks for the patch. It is one thing i wanted to have implemented, just i hadn't found the time to do it. There were some problems with the patch (like not handling protocol reconfiguration, unnecessary function locate_route_with_bfd_req() and some minor issues) and it is a simple thing i rather implemented it anew. See: https://gitlab.labs.nic.cz/labs/bird/commit/538264cf1a7690d90b2953aebff21958... It depends on a previous patch for general route options. There is a slightly different syntax, 'bfd' is one option in a block of options: route 10.0.0.0/24 via 10.1.1.1 { bfd; }; Also there is a minor semantic change - BFD session is required to be established before the route is activated. Although other BFD-enhanced protocols use BFD just in advisory manner (i.e. if BFD session cannot be established, it is just disregarded), seems to me that for static protocol, which does not have native way to establish liveness of a neighbor, the mandatory manner (no session -> no route) makes much more sense. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."