Re: [PATCH] RPKI: Fix unnecessary reconnection on reconfiguration

On Wed, Jun 03, 2020 at 02:21:17PM +0900, Kazuki Yamaguchi wrote:

Compare the new timing parameters with the old configuration, not with the temporary state of the current connection.

The timing values in struct rpki_cache is updated by a version 1 End Of Data PDU, unless this behavior is suppressed by the configuration explicitly by the "keep" keyword. Consequently, every reconfiguration of BIRD triggers a reconnection even if it is not necessary.

Thanks, merged -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."