Ondrej Zajicek <santiago@crfreenet.org> writes:
On Sat, Feb 03, 2018 at 09:40:56PM +0100, Toke Høiland-Jørgensen wrote:
This adds support for source-specific IPv6 routes to Bird core. This is based on Dean Luga's original patch, with the review comments addressed. Sadr support is added to network address parsing in confbase.Y and to the kernel protocol on Linux.
First, some general comments:
Put sadr_ip6 variant consistently above mpls variant. There are several places where it is in reverse.
Sure; fixed a couple of those, but guess I missed some.
If you do not object, i would much prefer *_ip6_sadr than *_sadr_ip6 (also in uppercase variants). It will also be consistent with user visible channel and table keywords for this type.
Fine with me. Actually thought about changing this already, but then I was too lazy ;) Will fix and resubmit. What about the issue with 'learn'? :) -Toke