On Mon, May 02, 2016 at 07:07:50PM +0200, Toke Høiland-Jørgensen wrote:
An interface reconfiguration may change the hello interval. Section 3.4.1 of the RFC specifies that either the change shouldn't be applied until the next hello is due, or an additional hello should be sent immediately. This does the latter.
if (ifa->up) + { + babel_send_hello(ifa, 0); babel_iface_kick_timer(ifa); + }
I am not sure if this is correct - even if you add babel_send_hello(), the next hello is scheduled based on ifa->next_hello. It seems to me that the old code was correct - it waited based on old interval and then sent hello with the new value. The new code sends hello immediately with the new value, but then waits based on old interval (ifa->next_hello) for the next regular hello to send. -- Elen sila lumenn' omentielvo Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org) OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net) "To err is human -- to blame it on a computer is even more so."