Hi, On Tue, Jul 14, 2015 at 06:33:30 +0000, Steve Atkinson wrote:
Hi,
This is my first submission into the community, it is a change to the static protocol to support the addition / deletion of static routes based on the availability of the gateway as determined by BFD. This was implemented as a proof of concept for one of our customers, it appears to work although has only been tested against the bfd-beacon, with routes exported to a remote BGP associated router.
Interesting idea, really. I am not a bird developer, just stumbled over some cosmetic things: diff -Naur bird-1.5.0/proto/static/static.c bird/proto/static/static.c --- bird-1.5.0/proto/static/static.c 2015-06-08 11:11:21.000000000 +0000 +++ bird/proto/static/static.c 2015-06-23 07:59:24.000000000 +0000 @@ -47,6 +47,12 @@ #include "static.h" +#ifdef HACK_BFD_IN +#include "nest/bfd.h" +#endif You should move this into static.h, as static.h uses bfd_request, so it needs this too. + +void static_bfd_notify(struct bfd_request *req); + Make that into a "static void"? It's only needed in this file, so no need to have it non-static.
Regards
Steve [...]
Cheers Christian -- www.cosmokey.com