18 Apr
2022
18 Apr
'22
2:43 a.m.
For example bird can check that the hold timer proposed by a peer is at least 2 times greater than the local keepalive timer as in the attached patch. On Mon, Apr 11, 2022 at 1:12 PM Alexander Zubkov <green@qrator.net> wrote:
Hi,
Found interesting thing. If I set "keepalive time" for a BGP session, this values is not modified after the hold time negotiations and as a result I can get a BGP session with hold timer less than keepalive timer and it will die due to hold timer expired after some time. https://gitlab.nic.cz/labs/bird/-/blob/692055e3df6cc9f0d428d3b0dd8cdd8e825eb... I think more correct bahivour would be to close the BGP session with unacceptable hold timer error in such case.